Repository: hive Updated Branches: refs/heads/master 116bf0bcb -> ab189f540
HIVE-19373: Add test cases that verifies ALTER change owner type on the HMS (Sergio Pena, reviewed by Peter Vary) Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/ab189f54 Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/ab189f54 Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/ab189f54 Branch: refs/heads/master Commit: ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb Parents: 116bf0b Author: Sergio Pena <[email protected]> Authored: Tue May 15 10:02:05 2018 -0500 Committer: Sergio Pena <[email protected]> Committed: Tue May 15 10:02:05 2018 -0500 ---------------------------------------------------------------------- .../hive/metastore/client/builder/TableBuilder.java | 11 ++++++++++- .../client/TestTablesCreateDropAlterTruncate.java | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/ab189f54/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java ---------------------------------------------------------------------- diff --git a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java index 055a46e..fed3dda 100644 --- a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java +++ b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java @@ -27,6 +27,7 @@ import org.apache.hadoop.hive.metastore.api.CreationMetadata; import org.apache.hadoop.hive.metastore.api.Database; import org.apache.hadoop.hive.metastore.api.FieldSchema; import org.apache.hadoop.hive.metastore.api.MetaException; +import org.apache.hadoop.hive.metastore.api.PrincipalType; import org.apache.hadoop.hive.metastore.api.Table; import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils; import org.apache.hadoop.hive.metastore.utils.SecurityUtils; @@ -53,7 +54,7 @@ public class TableBuilder extends StorageDescriptorBuilder<TableBuilder> { private Map<String, String> tableParams; private boolean rewriteEnabled, temporary; private Set<String> mvReferencedTables; - + private PrincipalType ownerType; public TableBuilder() { // Set some reasonable defaults @@ -94,6 +95,11 @@ public class TableBuilder extends StorageDescriptorBuilder<TableBuilder> { return this; } + public TableBuilder setOwnerType(PrincipalType ownerType) { + this.ownerType = ownerType; + return this; + } + public TableBuilder setViewOriginalText(String viewOriginalText) { this.viewOriginalText = viewOriginalText; return this; @@ -185,6 +191,9 @@ public class TableBuilder extends StorageDescriptorBuilder<TableBuilder> { if (tableName == null) { throw new MetaException("You must set the table name"); } + if (ownerType == null) { + ownerType = PrincipalType.USER; + } if (owner == null) { try { owner = SecurityUtils.getUser(); http://git-wip-us.apache.org/repos/asf/hive/blob/ab189f54/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java ---------------------------------------------------------------------- diff --git a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java b/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java index fe2d758..be9e7c9 100644 --- a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java +++ b/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java @@ -36,6 +36,7 @@ import org.apache.hadoop.hive.metastore.api.InvalidOperationException; import org.apache.hadoop.hive.metastore.api.MetaException; import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; import org.apache.hadoop.hive.metastore.api.Partition; +import org.apache.hadoop.hive.metastore.api.PrincipalType; import org.apache.hadoop.hive.metastore.api.SerDeInfo; import org.apache.hadoop.hive.metastore.api.SkewedInfo; import org.apache.hadoop.hive.metastore.api.StorageDescriptor; @@ -256,6 +257,7 @@ public class TestTablesCreateDropAlterTruncate extends MetaStoreClientTest { client.createTable(table); Table createdTable = client.getTable(table.getDbName(), table.getTableName()); + Assert.assertEquals("Comparing OwnerType", PrincipalType.USER, createdTable.getOwnerType()); Assert.assertNull("Comparing OwnerName", createdTable.getOwner()); Assert.assertNotEquals("Comparing CreateTime", 0, createdTable.getCreateTime()); Assert.assertEquals("Comparing LastAccessTime", 0, createdTable.getLastAccessTime()); @@ -1334,6 +1336,7 @@ public class TestTablesCreateDropAlterTruncate extends MetaStoreClientTest { .setDbName(DEFAULT_DATABASE) .setTableName("test_table_with_all_parameters_set") .setCreateTime(100) + .setOwnerType(PrincipalType.ROLE) .setOwner("owner") .setLastAccessTime(200) .addPartCol("part_col", "int", "part col comment")
