Repository: hive Updated Branches: refs/heads/master 2d097dcbf -> 5a3f12dd7
HIVE-20158 : Do Not Print StackTraces to STDERR in Base64TextOutputFormat (Andrew Sherman, reviewed by Vihang Karajgaonkar) Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/5a3f12dd Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/5a3f12dd Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/5a3f12dd Branch: refs/heads/master Commit: 5a3f12dd758918569dc60e2bb33fcf9f7c98c0ed Parents: 2d097dc Author: Andrew Sherman <asher...@cloudera.com> Authored: Thu Jul 26 14:11:48 2018 -0700 Committer: Vihang Karajgaonkar <vih...@cloudera.com> Committed: Thu Jul 26 14:11:48 2018 -0700 ---------------------------------------------------------------------- .../fileformat/base64/Base64TextInputFormat.java | 17 ++++++----------- .../fileformat/base64/Base64TextOutputFormat.java | 16 ++++++---------- 2 files changed, 12 insertions(+), 21 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/5a3f12dd/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java ---------------------------------------------------------------------- diff --git a/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java b/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java index 4658469..9164aaa 100644 --- a/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java +++ b/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java @@ -19,13 +19,12 @@ package org.apache.hadoop.hive.contrib.fileformat.base64; import java.io.IOException; -import java.io.UnsupportedEncodingException; import java.util.Arrays; import java.lang.reflect.Constructor; import java.lang.reflect.InvocationTargetException; +import java.nio.charset.StandardCharsets; import org.apache.commons.codec.binary.Base64; -import org.apache.hadoop.hive.shims.ShimLoader; import org.apache.hadoop.io.BytesWritable; import org.apache.hadoop.io.LongWritable; import org.apache.hadoop.io.Text; @@ -131,15 +130,11 @@ public class Base64TextInputFormat implements @Override public void configure(JobConf job) { - try { - String signatureString = job.get("base64.text.input.format.signature"); - if (signatureString != null) { - signature = signatureString.getBytes("UTF-8"); - } else { - signature = new byte[0]; - } - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + String signatureString = job.get("base64.text.input.format.signature"); + if (signatureString != null) { + signature = signatureString.getBytes(StandardCharsets.UTF_8); + } else { + signature = new byte[0]; } } http://git-wip-us.apache.org/repos/asf/hive/blob/5a3f12dd/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java ---------------------------------------------------------------------- diff --git a/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java b/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java index 20bbc46..35c1e68 100644 --- a/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java +++ b/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java @@ -19,7 +19,7 @@ package org.apache.hadoop.hive.contrib.fileformat.base64; import java.io.IOException; -import java.io.UnsupportedEncodingException; +import java.nio.charset.StandardCharsets; import java.util.Properties; import org.apache.commons.codec.binary.Base64; @@ -105,15 +105,11 @@ public class Base64TextOutputFormat<K extends WritableComparable, V extends Writ @Override public void configure(JobConf job) { - try { - String signatureString = job.get("base64.text.output.format.signature"); - if (signatureString != null) { - signature = signatureString.getBytes("UTF-8"); - } else { - signature = new byte[0]; - } - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + String signatureString = job.get("base64.text.output.format.signature"); + if (signatureString != null) { + signature = signatureString.getBytes(StandardCharsets.UTF_8); + } else { + signature = new byte[0]; } } }
