This is an automated email from the ASF dual-hosted git repository.
ayushsaxena pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 39099d4c3fb HIVE-27113: Increasing default for
hive.thrift.client.max.message.size to 2147483647 bytes (#4704). (Riju Trivedi,
Reviewed by Ayush Saxena, John Sherman, Naveen Gangam)
39099d4c3fb is described below
commit 39099d4c3fba46cd9d6d755c55fae262257ef6bc
Author: rtrivedi12 <[email protected]>
AuthorDate: Mon Nov 6 05:54:48 2023 +0530
HIVE-27113: Increasing default for hive.thrift.client.max.message.size to
2147483647 bytes (#4704). (Riju Trivedi, Reviewed by Ayush Saxena, John
Sherman, Naveen Gangam)
---
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 8 ++++----
.../hive/service/cli/thrift/RetryingThriftCLIServiceClient.java | 3 ++-
.../org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java | 3 ++-
.../java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java | 7 ++++---
4 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
index a8378f097d3..3e3737ad757 100644
--- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
+++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
@@ -2944,10 +2944,10 @@ public class HiveConf extends Configuration {
HIVE_STATS_MAX_NUM_STATS("hive.stats.max.num.stats", (long) 10000,
"When the number of stats to be updated is huge, this value is used to
control the number of \n" +
" stats to be sent to HMS for update."),
- HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE("hive.thrift.client.max.message.size",
"1gb",
- new SizeValidator(-1L, true, (long) Integer.MAX_VALUE, true),
- "Thrift client configuration for max message size. 0 or -1 will use
the default defined in the Thrift " +
- "library. The upper limit is 2147483648 bytes (or 2gb)."),
+ HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE("hive.thrift.client.max.message.size",
"2147483647b",
+ new SizeValidator(-1L, true, (long) Integer.MAX_VALUE, true),
+ "Thrift client configuration for max message size. 0 or -1 will
use the default defined in the Thrift " +
+ "library. The upper limit is 2147483647 bytes."),
// Concurrency
HIVE_SUPPORT_CONCURRENCY("hive.support.concurrency", false,
"Whether Hive supports concurrency control or not. \n" +
diff --git
a/service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
b/service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
index 9079c652d0a..e75922287ec 100644
---
a/service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
+++
b/service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
@@ -311,7 +311,8 @@ public class RetryingThriftCLIServiceClient implements
InvocationHandler {
String host = conf.getVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST);
int port = conf.getIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT);
int maxThriftMessageSize = (int)
conf.getSizeVar(HiveConf.ConfVars.HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE);
- LOG.info("Connecting to " + host + ":" + port);
+ LOG.info("Connecting to {}:{} using a thrift max message of size: {}",
+ host, port, maxThriftMessageSize);
transport = HiveAuthUtils.getSocketTransport(host, port, 0,
maxThriftMessageSize);
((TSocket) transport).setTimeout((int)
conf.getTimeVar(HiveConf.ConfVars.SERVER_READ_SOCKET_TIMEOUT,
diff --git
a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
index 116d2a41598..9b7cbb82df6 100644
---
a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
+++
b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
@@ -612,7 +612,8 @@ public class HiveMetaStoreClient implements
IMetaStoreClient, AutoCloseable {
}
private <T extends TTransport> T configureThriftMaxMessageSize(T transport) {
- int maxThriftMessageSize = (int) MetastoreConf.getSizeVar(conf,
ConfVars.THRIFT_METASTORE_CLIENT_MAX_MESSAGE_SIZE);
+ int maxThriftMessageSize = (int) MetastoreConf.getSizeVar(
+ conf, ConfVars.THRIFT_METASTORE_CLIENT_MAX_MESSAGE_SIZE);
if (maxThriftMessageSize > 0) {
if (transport.getConfiguration() == null) {
LOG.warn("TTransport {} is returning a null Configuration, Thrift max
message size is not getting configured",
diff --git
a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
index 7208867eaa4..65449d4362c 100644
---
a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
+++
b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
@@ -1496,9 +1496,10 @@ public class MetastoreConf {
" corresponding service discovery servers e.g. a zookeeper.
Otherwise they are " +
"used as URIs for remote metastore."),
THRIFT_METASTORE_CLIENT_MAX_MESSAGE_SIZE("metastore.thrift.client.max.message.size",
- "hive.thrift.client.max.message.size", "1gb", new SizeValidator(-1L,
true, (long) Integer.MAX_VALUE, true),
- "Thrift client configuration for max message size. 0 or -1 will use
the default defined in the Thrift " +
- "library. The upper limit is 2147483648 bytes (or 2gb)."),
+ "hive.thrift.client.max.message.size", "2147483647b",
+ new SizeValidator(-1L, true, (long) Integer.MAX_VALUE, true),
+ "Thrift client configuration for max message size. 0 or -1 will
use the default defined in the Thrift " +
+ "library. The upper limit is 2147483647 bytes"),
THRIFT_SERVICE_DISCOVERY_MODE("metastore.service.discovery.mode",
"hive.metastore.service.discovery.mode",
"",
