(hive) branch master updated: HIVE-28217: Make default port effective (#5214). (Zhen Wang, reviewed by Ayush Saxena)

[ayushsaxena]

This is an automated email from the ASF dual-hosted git repository.

ayushsaxena pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 01e387a88fa HIVE-28217: Make default port effective (#5214). (Zhen 
Wang, reviewed by Ayush Saxena)
01e387a88fa is described below

commit 01e387a88fa1d53be0775b9c70ee64eb74e29811
Author: Zhen Wang <643348...@qq.com>
AuthorDate: Mon Apr 29 12:44:57 2024 +0800

    HIVE-28217: Make default port effective (#5214). (Zhen Wang, reviewed by 
Ayush Saxena)
---
 jdbc/src/java/org/apache/hive/jdbc/Utils.java              | 4 ++--
 jdbc/src/test/org/apache/hive/jdbc/TestHiveConnection.java | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/jdbc/src/java/org/apache/hive/jdbc/Utils.java 
b/jdbc/src/java/org/apache/hive/jdbc/Utils.java
index e3fb3edf810..87007e9e4ba 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/Utils.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/Utils.java
@@ -617,8 +617,8 @@ public class Utils {
           if (port <= 0) {
             port = Integer.parseInt(Utils.DEFAULT_PORT);
           }
-          connParams.setHost(jdbcBaseURI.getHost());
-          connParams.setPort(jdbcBaseURI.getPort());
+          connParams.setHost(host);
+          connParams.setPort(port);
         }
         // We check for invalid host, port while configuring connParams with 
configureConnParams()
         authorityStr = connParams.getHost() + ":" + connParams.getPort();
diff --git a/jdbc/src/test/org/apache/hive/jdbc/TestHiveConnection.java 
b/jdbc/src/test/org/apache/hive/jdbc/TestHiveConnection.java
index 71abe784488..9bb2f60a243 100644
--- a/jdbc/src/test/org/apache/hive/jdbc/TestHiveConnection.java
+++ b/jdbc/src/test/org/apache/hive/jdbc/TestHiveConnection.java
@@ -73,5 +73,8 @@ public class TestHiveConnection {
     Assert.assertEquals("cliservice", 
params.getSessionVars().get(JdbcConnectionParams.HTTP_PATH));
     Assert.assertEquals("60", 
params.getSessionVars().get(JdbcConnectionParams.SOCKET_TIMEOUT));
     Assert.assertEquals("true", 
params.getSessionVars().get(JdbcConnectionParams.JDBC_PARAM_REQUEST_TRACK));
+
+    JdbcConnectionParams nonPortParams = 
Utils.parseURL("jdbc:hive2://hello.host/default");
+    Assert.assertEquals(Integer.parseInt(Utils.DEFAULT_PORT), 
nonPortParams.getPort());
   }
 }