(hive) 01/02: HIVE-28309: fixed Task Execution Summary duration is not displayed (#5285) (Ryu Kobayashi reviewed by Butao Zhang, Laszlo Bodor)

[ayushsaxena]

This is an automated email from the ASF dual-hosted git repository.

ayushsaxena pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/hive.git

commit 823f8d26ff9fd5caa5317ca2964b6cc9ae2de408
Author: Ryu Kobayashi <beter....@gmail.com>
AuthorDate: Tue Jun 11 16:54:08 2024 +0900

    HIVE-28309: fixed Task Execution Summary duration is not displayed (#5285) 
(Ryu Kobayashi reviewed by Butao Zhang, Laszlo Bodor)
---
 .../hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java   | 12 ++++++------
 .../hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java    |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java 
b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
index c58e0c73c8c..132489e4906 100644
--- 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
+++ 
b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
@@ -51,14 +51,14 @@ class RenderStrategy {
     private long lastPrintTime = 0L;
     private String lastReport = null;
 
-    BaseUpdateFunction(TezJobMonitor monitor) {
+    BaseUpdateFunction(TezJobMonitor monitor, PerfLogger perfLogger) {
       this.monitor = monitor;
       print_interval = HiveConf.getTimeVar(
           monitor.getHiveConf(),
           HiveConf.ConfVars.HIVE_LOG_INCREMENTAL_PLAN_PROGRESS_INTERVAL,
           TimeUnit.MILLISECONDS
       );
-      perfLogger = SessionState.getPerfLogger();
+      this.perfLogger = perfLogger;
     }
 
     @Override
@@ -155,8 +155,8 @@ class RenderStrategy {
         
SessionState.get().getConf().getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_INPLACE_PROGRESS);
     private final ZoneId localTimeZone = 
SessionState.get().getConf().getLocalTimeZone();
 
-    LogToFileFunction(TezJobMonitor monitor) {
-      super(monitor);
+    LogToFileFunction(TezJobMonitor monitor, PerfLogger perfLogger) {
+      super(monitor, perfLogger);
     }
 
     @Override
@@ -186,8 +186,8 @@ class RenderStrategy {
      */
     private final InPlaceUpdate inPlaceUpdate;
 
-    InPlaceUpdateFunction(TezJobMonitor monitor) {
-      super(monitor);
+    InPlaceUpdateFunction(TezJobMonitor monitor, PerfLogger perfLogger) {
+      super(monitor, perfLogger);
       inPlaceUpdate = new 
InPlaceUpdate(SessionState.LogHelper.getInfoStream());
     }
 
diff --git 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 
b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
index fbbbf189e48..aab13378c8e 100644
--- 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
+++ 
b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
@@ -124,17 +124,17 @@ public class TezJobMonitor {
     this.dag = dag;
     this.context = ctx;
     console = SessionState.getConsole();
+    this.perfLogger = perfLogger;
     updateFunction = updateFunction();
     this.counters = counters;
-    this.perfLogger = perfLogger;
   }
 
   private RenderStrategy.UpdateFunction updateFunction() {
     return InPlaceUpdate.canRenderInPlace(hiveConf)
         && !SessionState.getConsole().getIsSilent()
         && !SessionState.get().isHiveServerQuery()
-        ? new RenderStrategy.InPlaceUpdateFunction(this)
-        : new RenderStrategy.LogToFileFunction(this);
+        ? new RenderStrategy.InPlaceUpdateFunction(this, perfLogger)
+        : new RenderStrategy.LogToFileFunction(this, perfLogger);
   }
 
   private boolean isProfilingEnabled() {