This is an automated email from the ASF dual-hosted git repository.

dkuzmenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 809b2f9c16b HIVE-23931: Addendum: ValidWriteIdList isn't used by 
get_*_constraints HMS APIs (#6135)
809b2f9c16b is described below

commit 809b2f9c16b84c9fdc252b8b050da3ae010f6c4b
Author: Denys Kuzmenko <[email protected]>
AuthorDate: Fri Oct 17 10:28:07 2025 +0200

    HIVE-23931: Addendum: ValidWriteIdList isn't used by get_*_constraints HMS 
APIs (#6135)
---
 .../org/apache/hadoop/hive/ql/metadata/Hive.java   |   5 -
 .../gen/thrift/gen-cpp/hive_metastore_types.cpp    |  24 +---
 .../src/gen/thrift/gen-cpp/hive_metastore_types.h  |  11 +-
 .../hive/metastore/api/PrimaryKeysRequest.java     | 122 ++-------------------
 .../gen-php/metastore/PrimaryKeysRequest.php       |  26 +----
 .../src/gen/thrift/gen-py/hive_metastore/ttypes.py |  18 +--
 .../src/gen/thrift/gen-rb/hive_metastore_types.rb  |   4 +-
 .../src/main/thrift/hive_metastore.thrift          |   3 +-
 8 files changed, 16 insertions(+), 197 deletions(-)

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
b/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
index 07b98266d85..5a60308513e 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
@@ -6640,10 +6640,8 @@ public List<SQLCheckConstraint> 
getCheckConstraintList(String dbName, String tbl
   public SQLAllTableConstraints getTableConstraints(String dbName, String 
tblName, long tableId)
       throws HiveException, NoSuchObjectException {
     try {
-      ValidWriteIdList validWriteIdList = getValidWriteIdList(dbName, tblName);
       AllTableConstraintsRequest request = new 
AllTableConstraintsRequest(dbName, tblName, getDefaultCatalog(conf));
       request.setTableId(tableId);
-      request.setValidWriteIdList(validWriteIdList != null ? 
validWriteIdList.writeToString() : null);
       return getMSC().getAllTableConstraints(request);
     } catch (NoSuchObjectException e) {
       throw e;
@@ -6658,10 +6656,7 @@ public TableConstraintsInfo getTableConstraints(String 
dbName, String tblName, b
     perfLogger.perfLogBegin(CLASS_NAME, PerfLogger.HIVE_GET_TABLE_CONSTRAINTS);
 
     try {
-
-      ValidWriteIdList validWriteIdList = getValidWriteIdList(dbName,tblName);
       AllTableConstraintsRequest request = new 
AllTableConstraintsRequest(dbName, tblName, getDefaultCatalog(conf));
-      request.setValidWriteIdList(validWriteIdList != null ? 
validWriteIdList.writeToString() : null);
       request.setTableId(tableId);
 
       SQLAllTableConstraints tableConstraints = 
getMSC().getAllTableConstraints(request);
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
index 1be1a922423..d99c4bdde0d 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
@@ -14628,11 +14628,6 @@ void PrimaryKeysRequest::__set_catName(const 
std::string& val) {
 __isset.catName = true;
 }
 
-void PrimaryKeysRequest::__set_validWriteIdList(const std::string& val) {
-  this->validWriteIdList = val;
-__isset.validWriteIdList = true;
-}
-
 void PrimaryKeysRequest::__set_tableId(const int64_t val) {
   this->tableId = val;
 __isset.tableId = true;
@@ -14692,14 +14687,6 @@ uint32_t 
PrimaryKeysRequest::read(::apache::thrift::protocol::TProtocol* iprot)
         }
         break;
       case 4:
-        if (ftype == ::apache::thrift::protocol::T_STRING) {
-          xfer += iprot->readString(this->validWriteIdList);
-          this->__isset.validWriteIdList = true;
-        } else {
-          xfer += iprot->skip(ftype);
-        }
-        break;
-      case 5:
         if (ftype == ::apache::thrift::protocol::T_I64) {
           xfer += iprot->readI64(this->tableId);
           this->__isset.tableId = true;
@@ -14741,13 +14728,8 @@ uint32_t 
PrimaryKeysRequest::write(::apache::thrift::protocol::TProtocol* oprot)
     xfer += oprot->writeString(this->catName);
     xfer += oprot->writeFieldEnd();
   }
-  if (this->__isset.validWriteIdList) {
-    xfer += oprot->writeFieldBegin("validWriteIdList", 
::apache::thrift::protocol::T_STRING, 4);
-    xfer += oprot->writeString(this->validWriteIdList);
-    xfer += oprot->writeFieldEnd();
-  }
   if (this->__isset.tableId) {
-    xfer += oprot->writeFieldBegin("tableId", 
::apache::thrift::protocol::T_I64, 5);
+    xfer += oprot->writeFieldBegin("tableId", 
::apache::thrift::protocol::T_I64, 4);
     xfer += oprot->writeI64(this->tableId);
     xfer += oprot->writeFieldEnd();
   }
@@ -14761,7 +14743,6 @@ void swap(PrimaryKeysRequest &a, PrimaryKeysRequest &b) 
{
   swap(a.db_name, b.db_name);
   swap(a.tbl_name, b.tbl_name);
   swap(a.catName, b.catName);
-  swap(a.validWriteIdList, b.validWriteIdList);
   swap(a.tableId, b.tableId);
   swap(a.__isset, b.__isset);
 }
@@ -14770,7 +14751,6 @@ PrimaryKeysRequest::PrimaryKeysRequest(const 
PrimaryKeysRequest& other531) {
   db_name = other531.db_name;
   tbl_name = other531.tbl_name;
   catName = other531.catName;
-  validWriteIdList = other531.validWriteIdList;
   tableId = other531.tableId;
   __isset = other531.__isset;
 }
@@ -14778,7 +14758,6 @@ PrimaryKeysRequest& PrimaryKeysRequest::operator=(const 
PrimaryKeysRequest& othe
   db_name = other532.db_name;
   tbl_name = other532.tbl_name;
   catName = other532.catName;
-  validWriteIdList = other532.validWriteIdList;
   tableId = other532.tableId;
   __isset = other532.__isset;
   return *this;
@@ -14789,7 +14768,6 @@ void PrimaryKeysRequest::printTo(std::ostream& out) 
const {
   out << "db_name=" << to_string(db_name);
   out << ", " << "tbl_name=" << to_string(tbl_name);
   out << ", " << "catName="; (__isset.catName ? (out << to_string(catName)) : 
(out << "<null>"));
-  out << ", " << "validWriteIdList="; (__isset.validWriteIdList ? (out << 
to_string(validWriteIdList)) : (out << "<null>"));
   out << ", " << "tableId="; (__isset.tableId ? (out << to_string(tableId)) : 
(out << "<null>"));
   out << ")";
 }
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h
index 6ae7016d0e6..ba4a231106a 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h
@@ -6222,9 +6222,8 @@ void swap(Schema &a, Schema &b);
 std::ostream& operator<<(std::ostream& out, const Schema& obj);
 
 typedef struct _PrimaryKeysRequest__isset {
-  _PrimaryKeysRequest__isset() : catName(false), validWriteIdList(false), 
tableId(true) {}
+  _PrimaryKeysRequest__isset() : catName(false), tableId(true) {}
   bool catName :1;
-  bool validWriteIdList :1;
   bool tableId :1;
 } _PrimaryKeysRequest__isset;
 
@@ -6237,7 +6236,6 @@ class PrimaryKeysRequest : public virtual 
::apache::thrift::TBase {
                      : db_name(),
                        tbl_name(),
                        catName(),
-                       validWriteIdList(),
                        tableId(-1LL) {
   }
 
@@ -6245,7 +6243,6 @@ class PrimaryKeysRequest : public virtual 
::apache::thrift::TBase {
   std::string db_name;
   std::string tbl_name;
   std::string catName;
-  std::string validWriteIdList;
   int64_t tableId;
 
   _PrimaryKeysRequest__isset __isset;
@@ -6256,8 +6253,6 @@ class PrimaryKeysRequest : public virtual 
::apache::thrift::TBase {
 
   void __set_catName(const std::string& val);
 
-  void __set_validWriteIdList(const std::string& val);
-
   void __set_tableId(const int64_t val);
 
   bool operator == (const PrimaryKeysRequest & rhs) const
@@ -6270,10 +6265,6 @@ class PrimaryKeysRequest : public virtual 
::apache::thrift::TBase {
       return false;
     else if (__isset.catName && !(catName == rhs.catName))
       return false;
-    if (__isset.validWriteIdList != rhs.__isset.validWriteIdList)
-      return false;
-    else if (__isset.validWriteIdList && !(validWriteIdList == 
rhs.validWriteIdList))
-      return false;
     if (__isset.tableId != rhs.__isset.tableId)
       return false;
     else if (__isset.tableId && !(tableId == rhs.tableId))
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java
index 2df2fe1f1d3..8532ac05eb4 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java
@@ -14,8 +14,7 @@
   private static final org.apache.thrift.protocol.TField DB_NAME_FIELD_DESC = 
new org.apache.thrift.protocol.TField("db_name", 
org.apache.thrift.protocol.TType.STRING, (short)1);
   private static final org.apache.thrift.protocol.TField TBL_NAME_FIELD_DESC = 
new org.apache.thrift.protocol.TField("tbl_name", 
org.apache.thrift.protocol.TType.STRING, (short)2);
   private static final org.apache.thrift.protocol.TField CAT_NAME_FIELD_DESC = 
new org.apache.thrift.protocol.TField("catName", 
org.apache.thrift.protocol.TType.STRING, (short)3);
-  private static final org.apache.thrift.protocol.TField 
VALID_WRITE_ID_LIST_FIELD_DESC = new 
org.apache.thrift.protocol.TField("validWriteIdList", 
org.apache.thrift.protocol.TType.STRING, (short)4);
-  private static final org.apache.thrift.protocol.TField TABLE_ID_FIELD_DESC = 
new org.apache.thrift.protocol.TField("tableId", 
org.apache.thrift.protocol.TType.I64, (short)5);
+  private static final org.apache.thrift.protocol.TField TABLE_ID_FIELD_DESC = 
new org.apache.thrift.protocol.TField("tableId", 
org.apache.thrift.protocol.TType.I64, (short)4);
 
   private static final org.apache.thrift.scheme.SchemeFactory 
STANDARD_SCHEME_FACTORY = new PrimaryKeysRequestStandardSchemeFactory();
   private static final org.apache.thrift.scheme.SchemeFactory 
TUPLE_SCHEME_FACTORY = new PrimaryKeysRequestTupleSchemeFactory();
@@ -23,7 +22,6 @@
   private @org.apache.thrift.annotation.Nullable java.lang.String db_name; // 
required
   private @org.apache.thrift.annotation.Nullable java.lang.String tbl_name; // 
required
   private @org.apache.thrift.annotation.Nullable java.lang.String catName; // 
optional
-  private @org.apache.thrift.annotation.Nullable java.lang.String 
validWriteIdList; // optional
   private long tableId; // optional
 
   /** The set of fields this struct contains, along with convenience methods 
for finding and manipulating them. */
@@ -31,8 +29,7 @@ public enum _Fields implements org.apache.thrift.TFieldIdEnum 
{
     DB_NAME((short)1, "db_name"),
     TBL_NAME((short)2, "tbl_name"),
     CAT_NAME((short)3, "catName"),
-    VALID_WRITE_ID_LIST((short)4, "validWriteIdList"),
-    TABLE_ID((short)5, "tableId");
+    TABLE_ID((short)4, "tableId");
 
     private static final java.util.Map<java.lang.String, _Fields> byName = new 
java.util.HashMap<java.lang.String, _Fields>();
 
@@ -54,9 +51,7 @@ public static _Fields findByThriftId(int fieldId) {
           return TBL_NAME;
         case 3: // CAT_NAME
           return CAT_NAME;
-        case 4: // VALID_WRITE_ID_LIST
-          return VALID_WRITE_ID_LIST;
-        case 5: // TABLE_ID
+        case 4: // TABLE_ID
           return TABLE_ID;
         default:
           return null;
@@ -101,7 +96,7 @@ public java.lang.String getFieldName() {
   // isset id assignments
   private static final int __TABLEID_ISSET_ID = 0;
   private byte __isset_bitfield = 0;
-  private static final _Fields optionals[] = 
{_Fields.CAT_NAME,_Fields.VALID_WRITE_ID_LIST,_Fields.TABLE_ID};
+  private static final _Fields optionals[] = 
{_Fields.CAT_NAME,_Fields.TABLE_ID};
   public static final java.util.Map<_Fields, 
org.apache.thrift.meta_data.FieldMetaData> metaDataMap;
   static {
     java.util.Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = 
new java.util.EnumMap<_Fields, 
org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
@@ -111,8 +106,6 @@ public java.lang.String getFieldName() {
         new 
org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
     tmpMap.put(_Fields.CAT_NAME, new 
org.apache.thrift.meta_data.FieldMetaData("catName", 
org.apache.thrift.TFieldRequirementType.OPTIONAL, 
         new 
org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
-    tmpMap.put(_Fields.VALID_WRITE_ID_LIST, new 
org.apache.thrift.meta_data.FieldMetaData("validWriteIdList", 
org.apache.thrift.TFieldRequirementType.OPTIONAL, 
-        new 
org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
     tmpMap.put(_Fields.TABLE_ID, new 
org.apache.thrift.meta_data.FieldMetaData("tableId", 
org.apache.thrift.TFieldRequirementType.OPTIONAL, 
         new 
org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
     metaDataMap = java.util.Collections.unmodifiableMap(tmpMap);
@@ -147,9 +140,6 @@ public PrimaryKeysRequest(PrimaryKeysRequest other) {
     if (other.isSetCatName()) {
       this.catName = other.catName;
     }
-    if (other.isSetValidWriteIdList()) {
-      this.validWriteIdList = other.validWriteIdList;
-    }
     this.tableId = other.tableId;
   }
 
@@ -162,7 +152,6 @@ public void clear() {
     this.db_name = null;
     this.tbl_name = null;
     this.catName = null;
-    this.validWriteIdList = null;
     this.tableId = -1L;
 
   }
@@ -239,30 +228,6 @@ public void setCatNameIsSet(boolean value) {
     }
   }
 
-  @org.apache.thrift.annotation.Nullable
-  public java.lang.String getValidWriteIdList() {
-    return this.validWriteIdList;
-  }
-
-  public void setValidWriteIdList(@org.apache.thrift.annotation.Nullable 
java.lang.String validWriteIdList) {
-    this.validWriteIdList = validWriteIdList;
-  }
-
-  public void unsetValidWriteIdList() {
-    this.validWriteIdList = null;
-  }
-
-  /** Returns true if field validWriteIdList is set (has been assigned a 
value) and false otherwise */
-  public boolean isSetValidWriteIdList() {
-    return this.validWriteIdList != null;
-  }
-
-  public void setValidWriteIdListIsSet(boolean value) {
-    if (!value) {
-      this.validWriteIdList = null;
-    }
-  }
-
   public long getTableId() {
     return this.tableId;
   }
@@ -311,14 +276,6 @@ public void setFieldValue(_Fields field, 
@org.apache.thrift.annotation.Nullable
       }
       break;
 
-    case VALID_WRITE_ID_LIST:
-      if (value == null) {
-        unsetValidWriteIdList();
-      } else {
-        setValidWriteIdList((java.lang.String)value);
-      }
-      break;
-
     case TABLE_ID:
       if (value == null) {
         unsetTableId();
@@ -342,9 +299,6 @@ public java.lang.Object getFieldValue(_Fields field) {
     case CAT_NAME:
       return getCatName();
 
-    case VALID_WRITE_ID_LIST:
-      return getValidWriteIdList();
-
     case TABLE_ID:
       return getTableId();
 
@@ -365,8 +319,6 @@ public boolean isSet(_Fields field) {
       return isSetTbl_name();
     case CAT_NAME:
       return isSetCatName();
-    case VALID_WRITE_ID_LIST:
-      return isSetValidWriteIdList();
     case TABLE_ID:
       return isSetTableId();
     }
@@ -413,15 +365,6 @@ public boolean equals(PrimaryKeysRequest that) {
         return false;
     }
 
-    boolean this_present_validWriteIdList = true && 
this.isSetValidWriteIdList();
-    boolean that_present_validWriteIdList = true && 
that.isSetValidWriteIdList();
-    if (this_present_validWriteIdList || that_present_validWriteIdList) {
-      if (!(this_present_validWriteIdList && that_present_validWriteIdList))
-        return false;
-      if (!this.validWriteIdList.equals(that.validWriteIdList))
-        return false;
-    }
-
     boolean this_present_tableId = true && this.isSetTableId();
     boolean that_present_tableId = true && that.isSetTableId();
     if (this_present_tableId || that_present_tableId) {
@@ -450,10 +393,6 @@ public int hashCode() {
     if (isSetCatName())
       hashCode = hashCode * 8191 + catName.hashCode();
 
-    hashCode = hashCode * 8191 + ((isSetValidWriteIdList()) ? 131071 : 524287);
-    if (isSetValidWriteIdList())
-      hashCode = hashCode * 8191 + validWriteIdList.hashCode();
-
     hashCode = hashCode * 8191 + ((isSetTableId()) ? 131071 : 524287);
     if (isSetTableId())
       hashCode = hashCode * 8191 + 
org.apache.thrift.TBaseHelper.hashCode(tableId);
@@ -499,16 +438,6 @@ public int compareTo(PrimaryKeysRequest other) {
         return lastComparison;
       }
     }
-    lastComparison = java.lang.Boolean.compare(isSetValidWriteIdList(), 
other.isSetValidWriteIdList());
-    if (lastComparison != 0) {
-      return lastComparison;
-    }
-    if (isSetValidWriteIdList()) {
-      lastComparison = 
org.apache.thrift.TBaseHelper.compareTo(this.validWriteIdList, 
other.validWriteIdList);
-      if (lastComparison != 0) {
-        return lastComparison;
-      }
-    }
     lastComparison = java.lang.Boolean.compare(isSetTableId(), 
other.isSetTableId());
     if (lastComparison != 0) {
       return lastComparison;
@@ -565,16 +494,6 @@ public java.lang.String toString() {
       }
       first = false;
     }
-    if (isSetValidWriteIdList()) {
-      if (!first) sb.append(", ");
-      sb.append("validWriteIdList:");
-      if (this.validWriteIdList == null) {
-        sb.append("null");
-      } else {
-        sb.append(this.validWriteIdList);
-      }
-      first = false;
-    }
     if (isSetTableId()) {
       if (!first) sb.append(", ");
       sb.append("tableId:");
@@ -658,15 +577,7 @@ public void read(org.apache.thrift.protocol.TProtocol 
iprot, PrimaryKeysRequest
               org.apache.thrift.protocol.TProtocolUtil.skip(iprot, 
schemeField.type);
             }
             break;
-          case 4: // VALID_WRITE_ID_LIST
-            if (schemeField.type == org.apache.thrift.protocol.TType.STRING) {
-              struct.validWriteIdList = iprot.readString();
-              struct.setValidWriteIdListIsSet(true);
-            } else { 
-              org.apache.thrift.protocol.TProtocolUtil.skip(iprot, 
schemeField.type);
-            }
-            break;
-          case 5: // TABLE_ID
+          case 4: // TABLE_ID
             if (schemeField.type == org.apache.thrift.protocol.TType.I64) {
               struct.tableId = iprot.readI64();
               struct.setTableIdIsSet(true);
@@ -704,13 +615,6 @@ public void write(org.apache.thrift.protocol.TProtocol 
oprot, PrimaryKeysRequest
           oprot.writeFieldEnd();
         }
       }
-      if (struct.validWriteIdList != null) {
-        if (struct.isSetValidWriteIdList()) {
-          oprot.writeFieldBegin(VALID_WRITE_ID_LIST_FIELD_DESC);
-          oprot.writeString(struct.validWriteIdList);
-          oprot.writeFieldEnd();
-        }
-      }
       if (struct.isSetTableId()) {
         oprot.writeFieldBegin(TABLE_ID_FIELD_DESC);
         oprot.writeI64(struct.tableId);
@@ -739,19 +643,13 @@ public void write(org.apache.thrift.protocol.TProtocol 
prot, PrimaryKeysRequest
       if (struct.isSetCatName()) {
         optionals.set(0);
       }
-      if (struct.isSetValidWriteIdList()) {
-        optionals.set(1);
-      }
       if (struct.isSetTableId()) {
-        optionals.set(2);
+        optionals.set(1);
       }
-      oprot.writeBitSet(optionals, 3);
+      oprot.writeBitSet(optionals, 2);
       if (struct.isSetCatName()) {
         oprot.writeString(struct.catName);
       }
-      if (struct.isSetValidWriteIdList()) {
-        oprot.writeString(struct.validWriteIdList);
-      }
       if (struct.isSetTableId()) {
         oprot.writeI64(struct.tableId);
       }
@@ -764,16 +662,12 @@ public void read(org.apache.thrift.protocol.TProtocol 
prot, PrimaryKeysRequest s
       struct.setDb_nameIsSet(true);
       struct.tbl_name = iprot.readString();
       struct.setTbl_nameIsSet(true);
-      java.util.BitSet incoming = iprot.readBitSet(3);
+      java.util.BitSet incoming = iprot.readBitSet(2);
       if (incoming.get(0)) {
         struct.catName = iprot.readString();
         struct.setCatNameIsSet(true);
       }
       if (incoming.get(1)) {
-        struct.validWriteIdList = iprot.readString();
-        struct.setValidWriteIdListIsSet(true);
-      }
-      if (incoming.get(2)) {
         struct.tableId = iprot.readI64();
         struct.setTableIdIsSet(true);
       }
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/PrimaryKeysRequest.php
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/PrimaryKeysRequest.php
index 95d523619c9..5222d4d068a 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/PrimaryKeysRequest.php
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/PrimaryKeysRequest.php
@@ -37,11 +37,6 @@ class PrimaryKeysRequest
             'type' => TType::STRING,
         ),
         4 => array(
-            'var' => 'validWriteIdList',
-            'isRequired' => false,
-            'type' => TType::STRING,
-        ),
-        5 => array(
             'var' => 'tableId',
             'isRequired' => false,
             'type' => TType::I64,
@@ -60,10 +55,6 @@ class PrimaryKeysRequest
      * @var string
      */
     public $catName = null;
-    /**
-     * @var string
-     */
-    public $validWriteIdList = null;
     /**
      * @var int
      */
@@ -81,9 +72,6 @@ class PrimaryKeysRequest
             if (isset($vals['catName'])) {
                 $this->catName = $vals['catName'];
             }
-            if (isset($vals['validWriteIdList'])) {
-                $this->validWriteIdList = $vals['validWriteIdList'];
-            }
             if (isset($vals['tableId'])) {
                 $this->tableId = $vals['tableId'];
             }
@@ -131,13 +119,6 @@ class PrimaryKeysRequest
                     }
                     break;
                 case 4:
-                    if ($ftype == TType::STRING) {
-                        $xfer += $input->readString($this->validWriteIdList);
-                    } else {
-                        $xfer += $input->skip($ftype);
-                    }
-                    break;
-                case 5:
                     if ($ftype == TType::I64) {
                         $xfer += $input->readI64($this->tableId);
                     } else {
@@ -173,13 +154,8 @@ class PrimaryKeysRequest
             $xfer += $output->writeString($this->catName);
             $xfer += $output->writeFieldEnd();
         }
-        if ($this->validWriteIdList !== null) {
-            $xfer += $output->writeFieldBegin('validWriteIdList', 
TType::STRING, 4);
-            $xfer += $output->writeString($this->validWriteIdList);
-            $xfer += $output->writeFieldEnd();
-        }
         if ($this->tableId !== null) {
-            $xfer += $output->writeFieldBegin('tableId', TType::I64, 5);
+            $xfer += $output->writeFieldBegin('tableId', TType::I64, 4);
             $xfer += $output->writeI64($this->tableId);
             $xfer += $output->writeFieldEnd();
         }
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
index a8df9cc6893..755e124ed1c 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
@@ -8357,17 +8357,15 @@ class PrimaryKeysRequest(object):
      - db_name
      - tbl_name
      - catName
-     - validWriteIdList
      - tableId
 
     """
 
 
-    def __init__(self, db_name=None, tbl_name=None, catName=None, 
validWriteIdList=None, tableId=-1,):
+    def __init__(self, db_name=None, tbl_name=None, catName=None, tableId=-1,):
         self.db_name = db_name
         self.tbl_name = tbl_name
         self.catName = catName
-        self.validWriteIdList = validWriteIdList
         self.tableId = tableId
 
     def read(self, iprot):
@@ -8395,11 +8393,6 @@ def read(self, iprot):
                 else:
                     iprot.skip(ftype)
             elif fid == 4:
-                if ftype == TType.STRING:
-                    self.validWriteIdList = iprot.readString().decode('utf-8', 
errors='replace') if sys.version_info[0] == 2 else iprot.readString()
-                else:
-                    iprot.skip(ftype)
-            elif fid == 5:
                 if ftype == TType.I64:
                     self.tableId = iprot.readI64()
                 else:
@@ -8426,12 +8419,8 @@ def write(self, oprot):
             oprot.writeFieldBegin('catName', TType.STRING, 3)
             oprot.writeString(self.catName.encode('utf-8') if 
sys.version_info[0] == 2 else self.catName)
             oprot.writeFieldEnd()
-        if self.validWriteIdList is not None:
-            oprot.writeFieldBegin('validWriteIdList', TType.STRING, 4)
-            oprot.writeString(self.validWriteIdList.encode('utf-8') if 
sys.version_info[0] == 2 else self.validWriteIdList)
-            oprot.writeFieldEnd()
         if self.tableId is not None:
-            oprot.writeFieldBegin('tableId', TType.I64, 5)
+            oprot.writeFieldBegin('tableId', TType.I64, 4)
             oprot.writeI64(self.tableId)
             oprot.writeFieldEnd()
         oprot.writeFieldStop()
@@ -33083,8 +33072,7 @@ def __ne__(self, other):
     (1, TType.STRING, 'db_name', 'UTF8', None, ),  # 1
     (2, TType.STRING, 'tbl_name', 'UTF8', None, ),  # 2
     (3, TType.STRING, 'catName', 'UTF8', None, ),  # 3
-    (4, TType.STRING, 'validWriteIdList', 'UTF8', None, ),  # 4
-    (5, TType.I64, 'tableId', None, -1, ),  # 5
+    (4, TType.I64, 'tableId', None, -1, ),  # 4
 )
 all_structs.append(PrimaryKeysResponse)
 PrimaryKeysResponse.thrift_spec = (
diff --git 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
index 3a12634f79e..44f6a048519 100644
--- 
a/standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
+++ 
b/standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
@@ -2770,14 +2770,12 @@ class PrimaryKeysRequest
   DB_NAME = 1
   TBL_NAME = 2
   CATNAME = 3
-  VALIDWRITEIDLIST = 4
-  TABLEID = 5
+  TABLEID = 4
 
   FIELDS = {
     DB_NAME => {:type => ::Thrift::Types::STRING, :name => 'db_name'},
     TBL_NAME => {:type => ::Thrift::Types::STRING, :name => 'tbl_name'},
     CATNAME => {:type => ::Thrift::Types::STRING, :name => 'catName', 
:optional => true},
-    VALIDWRITEIDLIST => {:type => ::Thrift::Types::STRING, :name => 
'validWriteIdList', :optional => true},
     TABLEID => {:type => ::Thrift::Types::I64, :name => 'tableId', :default => 
-1, :optional => true}
   }
 
diff --git 
a/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
b/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
index df072165529..ecea9c33777 100644
--- 
a/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
+++ 
b/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
@@ -754,8 +754,7 @@ struct PrimaryKeysRequest {
   1: required string db_name,
   2: required string tbl_name,
   3: optional string catName,
-  4: optional string validWriteIdList,
-  5: optional i64 tableId=-1
+  4: optional i64 tableId=-1
 }
 
 struct PrimaryKeysResponse {

Reply via email to