Repository: incubator-hivemall
Updated Branches:
  refs/heads/master 1e83eb55d -> c46c9c391


Close #56: [HIVEMAL-83] Fix wrong getV() arg on ffm_predict


Project: http://git-wip-us.apache.org/repos/asf/incubator-hivemall/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-hivemall/commit/c46c9c39
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hivemall/tree/c46c9c39
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hivemall/diff/c46c9c39

Branch: refs/heads/master
Commit: c46c9c3917ed9744c901979138ea5925bd2605aa
Parents: 1e83eb5
Author: Takuya Kitazawa <k.tak...@gmail.com>
Authored: Thu Mar 2 15:40:02 2017 +0900
Committer: myui <yuin...@gmail.com>
Committed: Thu Mar 2 15:40:02 2017 +0900

----------------------------------------------------------------------
 core/src/main/java/hivemall/fm/FFMPredictUDF.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/c46c9c39/core/src/main/java/hivemall/fm/FFMPredictUDF.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/hivemall/fm/FFMPredictUDF.java 
b/core/src/main/java/hivemall/fm/FFMPredictUDF.java
index 2de5170..48745d9 100644
--- a/core/src/main/java/hivemall/fm/FFMPredictUDF.java
+++ b/core/src/main/java/hivemall/fm/FFMPredictUDF.java
@@ -155,7 +155,7 @@ public final class FFMPredictUDF extends GenericUDF {
                 if (!model.getV(ei, jField, vij)) {
                     continue;
                 }
-                if (!model.getV(ej, iField, vij)) {
+                if (!model.getV(ej, iField, vji)) {
                     continue;
                 }
                 for (int f = 0; f < factors; f++) {

Reply via email to