Repository: incubator-hivemall Updated Branches: refs/heads/master 8e4351c5f -> 5ac14b7d8
http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/tools/RandomForestEnsembleUDAF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/tools/RandomForestEnsembleUDAF.java b/core/src/main/java/hivemall/smile/tools/RandomForestEnsembleUDAF.java index 452c5f4..2e87c2c 100644 --- a/core/src/main/java/hivemall/smile/tools/RandomForestEnsembleUDAF.java +++ b/core/src/main/java/hivemall/smile/tools/RandomForestEnsembleUDAF.java @@ -62,7 +62,7 @@ import org.apache.hadoop.io.IntWritable; @Description( name = "rf_ensemble", value = "_FUNC_(int yhat [, array<double> proba [, double model_weight=1.0]])" - + " - Returns emsebled prediction results in <int label, double probability, array<double> probabilities>") + + " - Returns ensembled prediction results in <int label, double probability, array<double> probabilities>") public final class RandomForestEnsembleUDAF extends AbstractGenericUDAFResolver { public RandomForestEnsembleUDAF() { @@ -91,7 +91,7 @@ public final class RandomForestEnsembleUDAF extends AbstractGenericUDAFResolver } if (!HiveUtils.isFloatingPointListTypeInfo(typeInfo[1])) { throw new UDFArgumentTypeException(1, - "ARRAY<double> is expected for posteriori: " + typeInfo[1]); + "ARRAY<double> is expected for a posteriori: " + typeInfo[1]); } return new RfEvaluatorV2(); } @@ -132,7 +132,7 @@ public final class RandomForestEnsembleUDAF extends AbstractGenericUDAFResolver // initialize output final ObjectInspector outputOI; - if (mode == Mode.PARTIAL1 || mode == Mode.PARTIAL2) {// terminatePartial + if (mode == Mode.PARTIAL1 || mode == Mode.PARTIAL2) {// terminatePartial outputOI = ObjectInspectorFactory.getStandardMapObjectInspector( PrimitiveObjectInspectorFactory.javaIntObjectInspector, PrimitiveObjectInspectorFactory.javaIntObjectInspector); @@ -466,7 +466,7 @@ public final class RandomForestEnsembleUDAF extends AbstractGenericUDAFResolver throw new HiveException("Predicted class " + yhat + " is out of bounds: " + _k); } if (posteriori.length != _k) { - throw new HiveException("Given |posteriori| " + posteriori.length + throw new HiveException("Given |a posteriori| " + posteriori.length + " is differs from expected one: " + _k); } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/tools/TreePredictUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/tools/TreePredictUDF.java b/core/src/main/java/hivemall/smile/tools/TreePredictUDF.java index ea3bc29..9b775bf 100644 --- a/core/src/main/java/hivemall/smile/tools/TreePredictUDF.java +++ b/core/src/main/java/hivemall/smile/tools/TreePredictUDF.java @@ -58,7 +58,7 @@ import org.apache.hadoop.io.Text; @Description(name = "tree_predict", value = "_FUNC_(string modelId, string model, array<double|string> features [, const string options | const boolean classification=false])" + " - Returns a prediction result of a random forest" - + " in <int value, array<double> posteriori> for classification and <double> for regression") + + " in <int value, array<double> a posteriori> for classification and <double> for regression") @UDFType(deterministic = true, stateful = false) public final class TreePredictUDF extends UDFWithOptions { @@ -222,13 +222,13 @@ public final class TreePredictUDF extends UDFWithOptions { if (feature.indexOf(':') != -1) { throw new UDFArgumentException( - "Invaliad feature format `<index>:<value>`: " + col); + "Invalid feature format `<index>:<value>`: " + col); } final int colIndex = Integer.parseInt(feature); if (colIndex < 0) { throw new UDFArgumentException( - "Col index MUST be greather than or equals to 0: " + colIndex); + "Col index MUST be greater than or equals to 0: " + colIndex); } probe.set(colIndex, value); } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/tools/TreePredictUDFv1.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/tools/TreePredictUDFv1.java b/core/src/main/java/hivemall/smile/tools/TreePredictUDFv1.java index 4053856..6e422a5 100644 --- a/core/src/main/java/hivemall/smile/tools/TreePredictUDFv1.java +++ b/core/src/main/java/hivemall/smile/tools/TreePredictUDFv1.java @@ -274,7 +274,7 @@ public final class TreePredictUDFv1 extends GenericUDF { if (classification) { return evaluateClassification(modelId, compressed, script, features); } else { - return evaluteRegression(modelId, compressed, script, features); + return evaluateRegression(modelId, compressed, script, features); } } @@ -292,7 +292,7 @@ public final class TreePredictUDFv1 extends GenericUDF { return new IntWritable(result); } - private DoubleWritable evaluteRegression(@Nonnull String modelId, boolean compressed, + private DoubleWritable evaluateRegression(@Nonnull String modelId, boolean compressed, @Nonnull Text script, double[] features) throws HiveException { if (!modelId.equals(prevModelId)) { this.prevModelId = modelId; http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/utils/SmileExtUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/utils/SmileExtUtils.java b/core/src/main/java/hivemall/smile/utils/SmileExtUtils.java index a665764..495c3ef 100644 --- a/core/src/main/java/hivemall/smile/utils/SmileExtUtils.java +++ b/core/src/main/java/hivemall/smile/utils/SmileExtUtils.java @@ -228,7 +228,7 @@ public final class SmileExtUtils { } @Nonnull - public static int[] classLables(@Nonnull final int[] y) throws HiveException { + public static int[] classLabels(@Nonnull final int[] y) throws HiveException { final int[] labels = smile.math.Math.unique(y); Arrays.sort(labels); @@ -420,7 +420,7 @@ public final class SmileExtUtils { /** * Generates an evenly distributed range of hue values in the HSV color scale. - * + * * @return colors */ public static double[] getColorBrew(@Nonnegative int n) { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/utils/SmileTaskExecutor.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/utils/SmileTaskExecutor.java b/core/src/main/java/hivemall/smile/utils/SmileTaskExecutor.java index cbb0f04..48a94f1 100644 --- a/core/src/main/java/hivemall/smile/utils/SmileTaskExecutor.java +++ b/core/src/main/java/hivemall/smile/utils/SmileTaskExecutor.java @@ -84,7 +84,7 @@ public final class SmileTaskExecutor { return results; } - public void shotdown() { + public void shutdown() { if (exec != null) { exec.shutdownNow(); } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/smile/vm/StackMachine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/smile/vm/StackMachine.java b/core/src/main/java/hivemall/smile/vm/StackMachine.java index b5168fd..59a0638 100644 --- a/core/src/main/java/hivemall/smile/vm/StackMachine.java +++ b/core/src/main/java/hivemall/smile/vm/StackMachine.java @@ -275,7 +275,7 @@ public final class StackMachine { } else { Double v = valuesMap.get(currentOperation.operand); if (v == null) { - throw new VMRuntimeException("value is not binded: " + throw new VMRuntimeException("value is not bound: " + currentOperation.operand); } push(v); @@ -295,7 +295,7 @@ public final class StackMachine { if (name.equals("end")) { this.result = pop(); } else { - throw new VMRuntimeException("Machine code has wrong builin function :" + name); + throw new VMRuntimeException("Machine code has wrong built-in function :" + name); } } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/GenerateSeriesUDTF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/GenerateSeriesUDTF.java b/core/src/main/java/hivemall/tools/GenerateSeriesUDTF.java index 3792605..47ac427 100644 --- a/core/src/main/java/hivemall/tools/GenerateSeriesUDTF.java +++ b/core/src/main/java/hivemall/tools/GenerateSeriesUDTF.java @@ -60,7 +60,7 @@ public final class GenerateSeriesUDTF extends GenericUDTF { this.end = HiveUtils.getAsConstLong(argOIs[1]); if (start > end) { throw new UDFArgumentException("start '" + start - + "' must be less than or equlas to end '" + end + "'"); + + "' must be less than or equals to end '" + end + "'"); } return ObjectInspectorFactory.getStandardStructObjectInspector(fieldNames, fieldOIs); http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/array/ArrayUnionUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/array/ArrayUnionUDF.java b/core/src/main/java/hivemall/tools/array/ArrayUnionUDF.java index c1201d4..921bbfa 100644 --- a/core/src/main/java/hivemall/tools/array/ArrayUnionUDF.java +++ b/core/src/main/java/hivemall/tools/array/ArrayUnionUDF.java @@ -40,7 +40,7 @@ import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.Object * Return a list of unique entries for a given set of lists. * * <pre> - * {1, 2} ⪠{1, 2} = {1, 2}, + * {1, 2} ⪠{1, 2} = {1, 2}, * {1, 2} ⪠{2, 3} = {1, 2, 3}, * {1, 2, 3} ⪠{3, 4, 5} = {1, 2, 3, 4, 5} * </pre> @@ -95,9 +95,9 @@ public final class ArrayUnionUDF extends GenericUDF { for (int j = 0, len = oi.getListLength(undeferred); j < len; ++j) { Object nonStd = oi.getListElement(undeferred, j); - Object copyed = ObjectInspectorUtils.copyToStandardObject(nonStd, elemOI, + Object copied = ObjectInspectorUtils.copyToStandardObject(nonStd, elemOI, ObjectInspectorCopyOption.WRITABLE); - objectSet.add(copyed); + objectSet.add(copied); } } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/array/CollectAllUDAF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/array/CollectAllUDAF.java b/core/src/main/java/hivemall/tools/array/CollectAllUDAF.java index 6ac48b1..0ed4020 100644 --- a/core/src/main/java/hivemall/tools/array/CollectAllUDAF.java +++ b/core/src/main/java/hivemall/tools/array/CollectAllUDAF.java @@ -33,7 +33,7 @@ import org.apache.hadoop.hive.serde2.objectinspector.StandardListObjectInspector import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo; @Description(name = "collect_all", - value = "_FUNC_(x) - Retrurns a set of objects with duplicate elements eliminated") + value = "_FUNC_(x) - Returns a set of objects with duplicate elements eliminated") @Deprecated public class CollectAllUDAF extends AbstractGenericUDAFResolver { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/array/LastElementUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/array/LastElementUDF.java b/core/src/main/java/hivemall/tools/array/LastElementUDF.java index 3584cb8..91050b8 100644 --- a/core/src/main/java/hivemall/tools/array/LastElementUDF.java +++ b/core/src/main/java/hivemall/tools/array/LastElementUDF.java @@ -31,7 +31,7 @@ import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector; /** * Return the last element in an array. */ -@Description(name = "last_element", value = "_FUNC_(x) - Retturn the last element in an array") +@Description(name = "last_element", value = "_FUNC_(x) - Return the last element in an array") @UDFType(deterministic = true, stateful = false) public class LastElementUDF extends GenericUDF { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/compress/DeflateUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/compress/DeflateUDF.java b/core/src/main/java/hivemall/tools/compress/DeflateUDF.java index 26c4c0e..ca9062a 100644 --- a/core/src/main/java/hivemall/tools/compress/DeflateUDF.java +++ b/core/src/main/java/hivemall/tools/compress/DeflateUDF.java @@ -40,7 +40,7 @@ import org.apache.hadoop.io.BytesWritable; import org.apache.hadoop.io.Text; @Description(name = "deflate", value = "_FUNC_(TEXT data [, const int compressionLevel]) - " - + "Returns a compressed BINARY obeject by using Deflater.", + + "Returns a compressed BINARY object by using Deflater.", extended = "The compression level must be in range [-1,9]") @UDFType(deterministic = true, stateful = false) public final class DeflateUDF extends GenericUDF { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java b/core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java index 5cdac4d..331874c 100644 --- a/core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java +++ b/core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java @@ -241,7 +241,7 @@ public final class UDAFToOrderedMap extends UDAFToMap { } void initBuffer(@Nonnull MapAggregationBuffer agg, @Nonnegative int size) { - Preconditions.checkArgument(size > 0, "size MUST be greather than zero: " + size); + Preconditions.checkArgument(size > 0, "size MUST be greater than zero: " + size); agg.container = new BoundedSortedMap<Object, Object>(size, true); agg.size = size; http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/text/SplitWordsUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/text/SplitWordsUDF.java b/core/src/main/java/hivemall/tools/text/SplitWordsUDF.java index 3f318f2..e015021 100644 --- a/core/src/main/java/hivemall/tools/text/SplitWordsUDF.java +++ b/core/src/main/java/hivemall/tools/text/SplitWordsUDF.java @@ -29,7 +29,7 @@ import org.apache.hadoop.io.Text; @Description( name = "split_words", - value = "_FUNC_(string query [, string regex]) - Returns an array<text> containing splitted strings") + value = "_FUNC_(string query [, string regex]) - Returns an array<text> containing split strings") @UDFType(deterministic = true, stateful = false) public final class SplitWordsUDF extends UDF { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/tools/vector/VectorDotUDF.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/tools/vector/VectorDotUDF.java b/core/src/main/java/hivemall/tools/vector/VectorDotUDF.java index 958595a..2aa3c03 100644 --- a/core/src/main/java/hivemall/tools/vector/VectorDotUDF.java +++ b/core/src/main/java/hivemall/tools/vector/VectorDotUDF.java @@ -47,7 +47,7 @@ import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectIn @UDFType(deterministic = true, stateful = false) public final class VectorDotUDF extends GenericUDF { - private Evaluator evalutor; + private Evaluator evaluator; @Override public ObjectInspector initialize(ObjectInspector[] argOIs) throws UDFArgumentException { @@ -64,9 +64,9 @@ public final class VectorDotUDF extends GenericUDF { ObjectInspector argOI1 = argOIs[1]; if (HiveUtils.isNumberListOI(argOI1)) { - this.evalutor = new Dot2DVectors(xListOI, HiveUtils.asListOI(argOI1)); + this.evaluator = new Dot2DVectors(xListOI, HiveUtils.asListOI(argOI1)); } else if (HiveUtils.isNumberOI(argOI1)) { - this.evalutor = new Multiply2D1D(xListOI, argOI1); + this.evaluator = new Multiply2D1D(xListOI, argOI1); } else { throw new UDFArgumentException( "Expected array<number> or number for the send argument: " + argOI1.getTypeName()); @@ -84,7 +84,7 @@ public final class VectorDotUDF extends GenericUDF { return null; } - return evalutor.dot(arg0, arg1); + return evaluator.dot(arg0, arg1); } interface Evaluator extends Serializable { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/utils/collections/arrays/DoubleArray3D.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/utils/collections/arrays/DoubleArray3D.java b/core/src/main/java/hivemall/utils/collections/arrays/DoubleArray3D.java index 35feff9..b7c5590 100644 --- a/core/src/main/java/hivemall/utils/collections/arrays/DoubleArray3D.java +++ b/core/src/main/java/hivemall/utils/collections/arrays/DoubleArray3D.java @@ -66,7 +66,7 @@ public final class DoubleArray3D { } public void configure(final int dim1, final int dim2, final int dim3) { - int requiredSize = cardinarity(dim1, dim2, dim3); + int requiredSize = cardinality(dim1, dim2, dim3); if (requiredSize > capacity) { this.buffer = allocate(direct, requiredSize); this.capacity = requiredSize; @@ -130,7 +130,7 @@ public final class DoubleArray3D { return idx; } - private static int cardinarity(final int dim1, final int dim2, final int dim3) { + private static int cardinality(final int dim1, final int dim2, final int dim3) { if (dim1 <= 0 || dim2 <= 0 || dim3 <= 0) { throw new IllegalArgumentException("Detected negative dimension size. dim1=" + dim1 + ", dim2=" + dim2 + ", dim3=" + dim3); http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/utils/hadoop/HiveUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/utils/hadoop/HiveUtils.java b/core/src/main/java/hivemall/utils/hadoop/HiveUtils.java index 1be1a01..f3fe703 100644 --- a/core/src/main/java/hivemall/utils/hadoop/HiveUtils.java +++ b/core/src/main/java/hivemall/utils/hadoop/HiveUtils.java @@ -959,7 +959,7 @@ public final class HiveUtils { break; default: throw new UDFArgumentTypeException(0, - "Unxpected type '" + argOI.getTypeName() + "' is passed."); + "Unexpected type '" + argOI.getTypeName() + "' is passed."); } return oi; } @@ -986,7 +986,7 @@ public final class HiveUtils { break; default: throw new UDFArgumentTypeException(0, - "Unxpected type '" + argOI.getTypeName() + "' is passed."); + "Unexpected type '" + argOI.getTypeName() + "' is passed."); } return oi; } @@ -1007,7 +1007,7 @@ public final class HiveUtils { break; default: throw new UDFArgumentTypeException(0, - "Unxpected type '" + argOI.getTypeName() + "' is passed."); + "Unexpected type '" + argOI.getTypeName() + "' is passed."); } return oi; } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/main/java/hivemall/utils/math/MatrixUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/hivemall/utils/math/MatrixUtils.java b/core/src/main/java/hivemall/utils/math/MatrixUtils.java index 2fd8193..dda77d3 100644 --- a/core/src/main/java/hivemall/utils/math/MatrixUtils.java +++ b/core/src/main/java/hivemall/utils/math/MatrixUtils.java @@ -43,11 +43,11 @@ public final class MatrixUtils { /** * Solve Yule-walker equation by Levinson-Durbin Recursion. - * + * * <pre> * R_j = â_{i=1}^{k} A_i R_{j-i} where j = 1..k, R_{-i} = R'_i * </pre> - * + * * @see <a * href="http://www.emptyloop.com/technotes/a%20tutorial%20on%20linear%20prediction%20and%20levinson-durbin.pdf";>Cedrick * Collomb: A tutorial on linear prediction and Levinson-Durbin</a> @@ -122,7 +122,7 @@ public final class MatrixUtils { U[i] = A[i]; V[k + 1 - i] = A[i]; } - V[k + 1] = 1.0; // U[k + 1] = 0.0; + V[k + 1] = 1.0; // U[k + 1] = 0.0; for (int i = 0, threshold = k + 2; i < threshold; i++) { A[i] = U[i] + lambda * V[i]; } @@ -237,7 +237,7 @@ public final class MatrixUtils { @Nonnull public static RealMatrix[][] toeplitz(@Nonnull final RealMatrix[] c, final int dim) { Preconditions.checkArgument(dim >= 1, "Invalid dimension: " + dim); - Preconditions.checkArgument(c.length >= dim, "|c| must be greather than " + dim + ": " + Preconditions.checkArgument(c.length >= dim, "|c| must be greater than " + dim + ": " + c.length); /* @@ -284,7 +284,7 @@ public final class MatrixUtils { @Nonnull public static double[][] toeplitz(@Nonnull final double[] c, final int dim) { Preconditions.checkArgument(dim >= 1, "Invalid dimension: " + dim); - Preconditions.checkArgument(c.length >= dim, "|c| must be greather than " + dim + ": " + Preconditions.checkArgument(c.length >= dim, "|c| must be greater than " + dim + ": " + c.length); /* @@ -319,9 +319,9 @@ public final class MatrixUtils { @Nonnull public static double[] flatten(@Nonnull final RealMatrix[][] grid) { - Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greather than 1"); + Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greater than 1"); Preconditions.checkArgument(grid[0].length >= 1, - "The number of cols must be greather than 1"); + "The number of cols must be greater than 1"); final int rows = grid.length; final int cols = grid[0].length; @@ -350,7 +350,7 @@ public final class MatrixUtils { @Nonnull public static double[] flatten(@Nonnull final RealMatrix[] grid) { - Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greather than 1"); + Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greater than 1"); final int rows = grid.length; RealMatrix grid0 = grid[0]; @@ -403,9 +403,9 @@ public final class MatrixUtils { @Nonnull public static RealMatrix combinedMatrices(@Nonnull final RealMatrix[][] grid, final int dimensions) { - Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greather than 1"); + Preconditions.checkArgument(grid.length >= 1, "The number of rows must be greater than 1"); Preconditions.checkArgument(grid[0].length >= 1, - "The number of cols must be greather than 1"); + "The number of cols must be greater than 1"); Preconditions.checkArgument(dimensions > 0, "Dimension should be more than 0: ", dimensions); final int rows = grid.length; @@ -423,7 +423,7 @@ public final class MatrixUtils { @Nonnull public static RealMatrix combinedMatrices(@Nonnull final RealMatrix[] grid) { Preconditions.checkArgument(grid.length >= 1, - "The number of rows must be greather than 0: " + grid.length); + "The number of rows must be greater than 0: " + grid.length); final int rows = grid.length; final int rowDims = grid[0].getRowDimension(); @@ -480,7 +480,7 @@ public final class MatrixUtils { /** * L = A x R - * + * * @return a matrix A that minimizes A x R - L */ @Nonnull @@ -491,7 +491,7 @@ public final class MatrixUtils { /** * L = A x R - * + * * @return a matrix A that minimizes A x R - L */ @Nonnull @@ -511,8 +511,8 @@ public final class MatrixUtils { /** * Find the first singular vector/value of a matrix A based on the Power method. - * - * @see http + * + * @see http * ://www.cs.yale.edu/homes/el327/datamining2013aFiles/07_singular_value_decomposition.pdf * @param A target matrix * @param x0 initial vector http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/anomaly/ChangeFinder2DTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/anomaly/ChangeFinder2DTest.java b/core/src/test/java/hivemall/anomaly/ChangeFinder2DTest.java index 5c0409b..eb17881 100644 --- a/core/src/test/java/hivemall/anomaly/ChangeFinder2DTest.java +++ b/core/src/test/java/hivemall/anomaly/ChangeFinder2DTest.java @@ -130,7 +130,7 @@ public class ChangeFinder2DTest { } @Test - public void testPoissenDist() throws HiveException { + public void testPoissonDist() throws HiveException { final int examples = 10000; final int dims = 3; final PoissonDistribution[] poisson = new PoissonDistribution[] { http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/common/RandomizedAmplifierTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/common/RandomizedAmplifierTest.java b/core/src/test/java/hivemall/common/RandomizedAmplifierTest.java index 549434b..2524797 100644 --- a/core/src/test/java/hivemall/common/RandomizedAmplifierTest.java +++ b/core/src/test/java/hivemall/common/RandomizedAmplifierTest.java @@ -60,9 +60,9 @@ public class RandomizedAmplifierTest { private final Set<Integer> numset = new HashSet<Integer>(10000); @Override - public void onDrop(Integer droppped) { - //System.out.println(droppped); - numset.add(droppped); + public void onDrop(Integer dropped) { + //System.out.println(dropped); + numset.add(dropped); count++; } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/fm/ArrayModelTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/fm/ArrayModelTest.java b/core/src/test/java/hivemall/fm/ArrayModelTest.java index a346c16..9264479 100644 --- a/core/src/test/java/hivemall/fm/ArrayModelTest.java +++ b/core/src/test/java/hivemall/fm/ArrayModelTest.java @@ -111,7 +111,7 @@ public class ArrayModelTest { println("Accuracy = " + accuracy); } udtf.runTrainingIteration(10); - Assert.assertTrue("Expected accuracy greather than 0.95f: " + accuracy, accuracy > 0.95f); + Assert.assertTrue("Expected accuracy greater than 0.95f: " + accuracy, accuracy > 0.95f); } @Test http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/smile/regression/RegressionTreeTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/smile/regression/RegressionTreeTest.java b/core/src/test/java/hivemall/smile/regression/RegressionTreeTest.java index f3eb5e5..2a0612b 100644 --- a/core/src/test/java/hivemall/smile/regression/RegressionTreeTest.java +++ b/core/src/test/java/hivemall/smile/regression/RegressionTreeTest.java @@ -177,7 +177,7 @@ public class RegressionTreeTest { @Test public void testGraphvizOutput() throws HiveException, IOException, ParseException { - int maxLeafts = 10; + int maxLeafs = 10; String outputName = "predicted"; double[][] x = { {234.289, 235.6, 159.0, 107.608, 1947, 60.323}, @@ -200,15 +200,15 @@ public class RegressionTreeTest { double[] y = {83.0, 88.5, 88.2, 89.5, 96.2, 98.1, 99.0, 100.0, 101.2, 104.6, 108.4, 110.8, 112.6, 114.2, 115.7, 116.9}; - debugPrint(graphvisOutput(x, y, maxLeafts, true, null, outputName)); + debugPrint(graphvisOutput(x, y, maxLeafs, true, null, outputName)); } - private static String graphvisOutput(double[][] x, double[] y, int maxLeafts, boolean dense, + private static String graphvisOutput(double[][] x, double[] y, int maxLeafs, boolean dense, String[] featureNames, String outputName) throws IOException, HiveException, ParseException { Attribute[] attrs = new Attribute[x[0].length]; Arrays.fill(attrs, new NumericAttribute()); - RegressionTree tree = new RegressionTree(attrs, matrix(x, dense), y, maxLeafts); + RegressionTree tree = new RegressionTree(attrs, matrix(x, dense), y, maxLeafs); Text model = new Text(Base91.encode(tree.serialize(true))); http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/tools/array/ConditionalEmitUDTFTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/tools/array/ConditionalEmitUDTFTest.java b/core/src/test/java/hivemall/tools/array/ConditionalEmitUDTFTest.java index b2585a1..bb12ffa 100644 --- a/core/src/test/java/hivemall/tools/array/ConditionalEmitUDTFTest.java +++ b/core/src/test/java/hivemall/tools/array/ConditionalEmitUDTFTest.java @@ -47,9 +47,9 @@ public class ConditionalEmitUDTFTest { udtf.setCollector(new Collector() { @Override public void collect(Object input) throws HiveException { - Object[] fowardObj = (Object[]) input; - Assert.assertEquals(1, fowardObj.length); - actual.add(fowardObj[0]); + Object[] forwardObj = (Object[]) input; + Assert.assertEquals(1, forwardObj.length); + actual.add(forwardObj[0]); } }); http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/core/src/test/java/hivemall/utils/math/FastMathTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/hivemall/utils/math/FastMathTest.java b/core/src/test/java/hivemall/utils/math/FastMathTest.java index 6892b72..7c088ed 100644 --- a/core/src/test/java/hivemall/utils/math/FastMathTest.java +++ b/core/src/test/java/hivemall/utils/math/FastMathTest.java @@ -68,7 +68,7 @@ public class FastMathTest { for (double x = 1d; x < 4_000_000d; x += 0.25d) { result1 += Math.sqrt(x); } - long elaspedTimeForSqrt = System.nanoTime() - startTime; + long elapsedTimeForSqrt = System.nanoTime() - startTime; // warm up for FastMath.sqrt double result2 = 0d; @@ -79,11 +79,11 @@ public class FastMathTest { for (double x = 1d; x < 4_000_000d; x += 0.25D) { result2 += FastMath.sqrt(x); } - long elaspedTimeForFastSqrt = System.nanoTime() - startTime; + long elapsedTimeForFastSqrt = System.nanoTime() - startTime; if (DEBUG) { - System.out.println("elaspedTimeForFastSqrt=" + elaspedTimeForFastSqrt - + " and elaspedTimeForSqrt=" + elaspedTimeForSqrt); + System.out.println("elapsedTimeForFastSqrt=" + elapsedTimeForFastSqrt + + " and elapsedTimeForSqrt=" + elapsedTimeForSqrt); } Assert.assertFalse(result1 == 0d); @@ -92,9 +92,9 @@ public class FastMathTest { /* Assert.assertTrue( - "Expected elaspedTimeForFastSqrt < elaspedTimeForSqrt while elaspedTimeForFastSqrt=" - + elaspedTimeForFastSqrt + " and elaspedTimeForSqrt=" + elaspedTimeForSqrt, - elaspedTimeForFastSqrt < elaspedTimeForSqrt); + "Expected elapsedTimeForFastSqrt < elapsedTimeForSqrt while elapsedTimeForFastSqrt=" + + elapsedTimeForFastSqrt + " and elapsedTimeForSqrt=" + elapsedTimeForSqrt, + elapsedTimeForFastSqrt < elapsedTimeForSqrt); */ } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/docs/gitbook/ft_engineering/vectorization.md ---------------------------------------------------------------------- diff --git a/docs/gitbook/ft_engineering/vectorization.md b/docs/gitbook/ft_engineering/vectorization.md index 21fcea7..45d4062 100644 --- a/docs/gitbook/ft_engineering/vectorization.md +++ b/docs/gitbook/ft_engineering/vectorization.md @@ -40,7 +40,7 @@ select vectorize_features(array("a"),*) from dual; > ["a:1.0"] -- has categorical feature -select vectorize_features(array("a","b","wheather"),"0.2","0.3","sunny") from dual; +select vectorize_features(array("a","b","Whether"),"0.2","0.3","sunny") from dual; > ["a:0.2","b:0.3","whether#sunny"] ``` http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/mixserv/src/main/java/hivemall/mix/metrics/ThroughputCounter.java ---------------------------------------------------------------------- diff --git a/mixserv/src/main/java/hivemall/mix/metrics/ThroughputCounter.java b/mixserv/src/main/java/hivemall/mix/metrics/ThroughputCounter.java index d60cd73..1547095 100644 --- a/mixserv/src/main/java/hivemall/mix/metrics/ThroughputCounter.java +++ b/mixserv/src/main/java/hivemall/mix/metrics/ThroughputCounter.java @@ -37,7 +37,7 @@ public final class ThroughputCounter extends GlobalTrafficShapingHandler { @Nonnull private final MixServerMetrics metrics; - private final AtomicLong lastChacked = new AtomicLong(); + private final AtomicLong lastChecked = new AtomicLong(); private final AtomicLong currentReads = new AtomicLong(); private final AtomicLong currentWrites = new AtomicLong(); @@ -66,7 +66,7 @@ public final class ThroughputCounter extends GlobalTrafficShapingHandler { @Override protected void doAccounting(TrafficCounter counter) { long currentTime = System.currentTimeMillis(); - long interval = currentTime - lastChacked.getAndSet(currentTime); + long interval = currentTime - lastChecked.getAndSet(currentTime); if (interval == 0) { return; } http://git-wip-us.apache.org/repos/asf/incubator-hivemall/blob/5ac14b7d/xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java ---------------------------------------------------------------------- diff --git a/xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java b/xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java index da6289d..207376f 100644 --- a/xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java +++ b/xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java @@ -109,7 +109,7 @@ public final class NativeLibLoader { } @Nonnull - private static String getPreffix(@Nonnull String fileName) { + private static String getPrefix(@Nonnull String fileName) { int point = fileName.lastIndexOf("."); if (point != -1) { return fileName.substring(0, point); @@ -131,7 +131,7 @@ public final class NativeLibLoader { // Create a temporary folder with a random number for the native lib final String uuid = UUID.randomUUID().toString(); final File tempFolder = new File(System.getProperty("java.io.tmpdir"), String.format( - "%s-%s", getPreffix(libName), uuid)); + "%s-%s", getPrefix(libName), uuid)); if (!tempFolder.exists()) { boolean created = tempFolder.mkdirs(); if (!created) {
