This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 4cdd5e3  HOP-2870 : ctrl/cmd click on a pipeline
     new 183fa25  Merge pull request #819 from mattcasters/master
4cdd5e3 is described below

commit 4cdd5e3918bc55d98ed02b8e9af067bb831f198c
Author: Matt Casters <[email protected]>
AuthorDate: Fri May 21 16:10:41 2021 +0200

    HOP-2870 : ctrl/cmd click on a pipeline
---
 .../hop/ui/core/dialog/EnterSelectionDialog.java   |   5 +-
 .../hopgui/file/pipeline/HopGuiPipelineGraph.java  | 102 +++++++++++++++------
 .../context/HopGuiPipelineTransformContext.java    |  29 ++++--
 .../hopgui/file/workflow/HopGuiWorkflowGraph.java  |  72 +++++++++++++--
 .../context/HopGuiWorkflowActionContext.java       |  27 ++++--
 .../workflow/messages/messages_en_US.properties    |  13 +--
 .../ui/hopgui/messages/messages_en_US.properties   |  13 +--
 7 files changed, 187 insertions(+), 74 deletions(-)

diff --git 
a/ui/src/main/java/org/apache/hop/ui/core/dialog/EnterSelectionDialog.java 
b/ui/src/main/java/org/apache/hop/ui/core/dialog/EnterSelectionDialog.java
index bcce635..b271357 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/dialog/EnterSelectionDialog.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/dialog/EnterSelectionDialog.java
@@ -252,7 +252,6 @@ public class EnterSelectionDialog extends Dialog {
       fdlSelection = new FormData();
       fdlSelection.left = new FormAttachment(0, 0);
       fdlSelection.top = new FormAttachment(treeTb, 10);
-      wlSelection.setLayoutData(fdlSelection);
     } else {
       // From transform line
       wlSelection = new Label(shell, SWT.NONE);
@@ -260,8 +259,8 @@ public class EnterSelectionDialog extends Dialog {
       props.setLook(wlSelection);
       fdlSelection = new FormData();
       fdlSelection.left = new FormAttachment(0, 0);
-      wlSelection.setLayoutData(fdlSelection);
     }
+    wlSelection.setLayoutData(fdlSelection);
 
     int options = SWT.LEFT | SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL;
     if (multi) {
@@ -371,7 +370,7 @@ public class EnterSelectionDialog extends Dialog {
 
     getData();
 
-    wOk.setFocus();
+    wSelection.setFocus();
 
     BaseDialog.defaultShellHandling(shell, c -> ok(), c -> cancel());
 
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
index c2c0604..4b89108 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
@@ -85,6 +85,7 @@ import 
org.apache.hop.pipeline.engines.local.LocalPipelineRunConfiguration;
 import 
org.apache.hop.pipeline.engines.local.LocalPipelineRunConfiguration.SampleType;
 import org.apache.hop.pipeline.transform.IRowDistribution;
 import org.apache.hop.pipeline.transform.ITransformIOMeta;
+import org.apache.hop.pipeline.transform.ITransformMeta;
 import org.apache.hop.pipeline.transform.RowAdapter;
 import org.apache.hop.pipeline.transform.RowDistributionPluginType;
 import org.apache.hop.pipeline.transform.TransformErrorMeta;
@@ -172,7 +173,6 @@ import org.eclipse.swt.widgets.Canvas;
 import org.eclipse.swt.widgets.Combo;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
-import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Listener;
 import org.eclipse.swt.widgets.Menu;
 import org.eclipse.swt.widgets.MenuItem;
@@ -213,7 +213,6 @@ public class HopGuiPipelineGraph extends HopGuiAbstractGraph
         MouseListener,
         MouseMoveListener,
         MouseTrackListener,
-        KeyListener,
         IHasLogChannel,
         ILogParentProvided, // TODO: Aren't these the same?
         IHopFileTypeHandler,
@@ -572,7 +571,6 @@ public class HopGuiPipelineGraph extends HopGuiAbstractGraph
       canvas.addMouseMoveListener(this);
       canvas.addMouseTrackListener(this);
     }
-    canvas.addKeyListener(this);
 
     setBackground(GuiResource.getInstance().getColorBackground());
 
@@ -766,6 +764,11 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
           break;
 
         case TRANSFORM_ICON:
+          if (shift && control) {
+            openReferencedObject();
+            return;
+          }
+
           transformMeta = (TransformMeta) areaOwner.getOwner();
           currentTransform = transformMeta;
 
@@ -2020,33 +2023,6 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
   }
 
   @Override
-  public void keyPressed(KeyEvent e) {
-
-    if (e.character == 'E' && (e.stateMask & SWT.CTRL) != 0) {
-      checkErrorVisuals();
-    }
-
-    // SPACE : over a transform: show output fields...
-    if (e.character == ' ' && lastMove != null) {
-
-      Point real = lastMove;
-
-      // Hide the tooltip!
-      hideToolTips();
-
-      // Set the pop-up menu
-      TransformMeta transformMeta = pipelineMeta.getTransform(real.x, real.y, 
iconSize);
-      if (transformMeta != null) {
-        // OK, we found a transform, show the output fields...
-        inputOutputFields(transformMeta, false);
-      }
-    }
-  }
-
-  @Override
-  public void keyReleased(KeyEvent e) {}
-
-  @Override
   public boolean setFocus() {
     return (canvas != null && !canvas.isDisposed()) ? canvas.setFocus() : 
false;
   }
@@ -5053,6 +5029,7 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
       disabledImage = "ui/images/undo-disabled.svg",
       separator = true)
   @GuiKeyboardShortcut(control = true, key = 'z')
+  @GuiOsxKeyboardShortcut(command = true, key = 'z')
   @Override
   public void undo() {
     pipelineUndoDelegate.undoPipelineAction(this, pipelineMeta);
@@ -5067,6 +5044,7 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
       image = "ui/images/redo.svg",
       disabledImage = "ui/images/redo-disabled.svg")
   @GuiKeyboardShortcut(control = true, shift = true, key = 'z')
+  @GuiOsxKeyboardShortcut(command = true, shift = true, key = 'z')
   @Override
   public void redo() {
     pipelineUndoDelegate.redoPipelineAction(this, pipelineMeta);
@@ -5211,6 +5189,70 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
         pipelineMeta, Arrays.asList(context.getTransformMeta()), 
Collections.emptyList());
   }
 
+  @GuiKeyboardShortcut(key = ' ')
+  @GuiOsxKeyboardShortcut(key = ' ')
+  public void showOutputFields() {
+    if (lastMove != null) {
+
+      // Hide the tooltip!
+      hideToolTips();
+
+      // Find the transform
+      TransformMeta transformMeta = pipelineMeta.getTransform(lastMove.x, 
lastMove.y, iconSize);
+      if (transformMeta != null) {
+        // Show the output fields...
+        //
+        inputOutputFields(transformMeta, false);
+      }
+    }
+  }
+
+  @GuiKeyboardShortcut(key = 'z')
+  @GuiOsxKeyboardShortcut(key = 'z')
+  public void openReferencedObject() {
+    if (lastMove != null) {
+
+      // Hide the tooltip!
+      hideToolTips();
+
+      // Find the transform
+      TransformMeta transformMeta = pipelineMeta.getTransform(lastMove.x, 
lastMove.y, iconSize);
+      if (transformMeta != null) {
+
+        // Open referenced object...
+        //
+        ITransformMeta iTransformMeta = transformMeta.getTransform();
+        String[] objectDescriptions = 
iTransformMeta.getReferencedObjectDescriptions();
+        if (objectDescriptions == null || objectDescriptions.length == 0) {
+          return;
+        }
+        // Only one reference?: open immediately
+        //
+        if (objectDescriptions.length == 1) {
+          HopGuiPipelineTransformContext.openReferencedObject(
+              pipelineMeta, variables, iTransformMeta, objectDescriptions[0], 
0);
+        } else {
+          // Show Selection dialog...
+          //
+          EnterSelectionDialog dialog =
+              new EnterSelectionDialog(
+                  getShell(),
+                  objectDescriptions,
+                  BaseMessages.getString(
+                      PKG, 
"HopGuiPipelineGraph.OpenReferencedObject.Selection.Title"),
+                  BaseMessages.getString(
+                      PKG, 
"HopGuiPipelineGraph.OpenReferencedObject.Selection.Message"));
+          String answer = dialog.open(0);
+          if (answer != null) {
+            int index = dialog.getSelectionNr();
+            HopGuiPipelineTransformContext.openReferencedObject(
+                pipelineMeta, variables, iTransformMeta, answer, index);
+          }
+        }
+      }
+    }
+  }
+
   @Override
   public List<IGuiContextHandler> getContextHandlers() {
     List<IGuiContextHandler> handlers = new ArrayList<>();
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/context/HopGuiPipelineTransformContext.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/context/HopGuiPipelineTransformContext.java
index b35cf6d..b675a6c 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/context/HopGuiPipelineTransformContext.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/context/HopGuiPipelineTransformContext.java
@@ -6,7 +6,7 @@
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *       http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -17,11 +17,13 @@
 
 package org.apache.hop.ui.hopgui.file.pipeline.context;
 
+import org.apache.hop.core.Const;
 import org.apache.hop.core.file.IHasFilename;
 import org.apache.hop.core.gui.Point;
 import org.apache.hop.core.gui.plugin.action.GuiAction;
 import org.apache.hop.core.gui.plugin.action.GuiActionLambdaBuilder;
 import org.apache.hop.core.gui.plugin.action.GuiActionType;
+import org.apache.hop.core.variables.IVariables;
 import org.apache.hop.pipeline.PipelineMeta;
 import org.apache.hop.pipeline.transform.ITransformMeta;
 import org.apache.hop.pipeline.transform.TransformMeta;
@@ -88,10 +90,17 @@ public class HopGuiPipelineTransformContext extends 
BaseGuiContextHandler
                 "transform-open-referenced-" + objectDescription,
                 GuiActionType.Info,
                 "open: " + objectDescription,
-                "This opens up the file referenced in the transform",
+                "This opens up the file referenced in the transform."
+                    + Const.CR
+                    + "You can hit key 'z' with the cursor over an Action icon 
or use CTRL+SHIFT+Click",
                 "ui/images/open.svg",
                 (shiftAction, controlAction, t) ->
-                    openReferencedObject(iTransformMeta, objectDescription, 
index));
+                    openReferencedObject(
+                        pipelineMeta,
+                        pipelineGraph.getVariables(),
+                        iTransformMeta,
+                        objectDescription,
+                        index));
         openReferencedAction.setCategory("Basic");
         openReferencedAction.setCategoryOrder("1");
         actions.add(openReferencedAction);
@@ -110,16 +119,18 @@ public class HopGuiPipelineTransformContext extends 
BaseGuiContextHandler
     return actions;
   }
 
-  private void openReferencedObject(
-      ITransformMeta iTransformMeta, String objectDescription, int index) {
+  public static final void openReferencedObject(
+      PipelineMeta pipelineMeta,
+      IVariables variables,
+      ITransformMeta iTransformMeta,
+      String objectDescription,
+      int index) {
     HopGui hopGui = HopGui.getInstance();
     try {
       IHasFilename hasFilename =
-          iTransformMeta.loadReferencedObject(
-              index, pipelineMeta.getMetadataProvider(), 
pipelineGraph.getVariables());
+          iTransformMeta.loadReferencedObject(index, 
pipelineMeta.getMetadataProvider(), variables);
       if (hasFilename != null) {
-        String filename =
-            pipelineGraph.getVariables().resolve(hasFilename.getFilename());
+        String filename = variables.resolve(hasFilename.getFilename());
 
         // Is this object already loaded?
         //
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
index 1c1b7da..2212b2d 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
@@ -6,7 +6,7 @@
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *       http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -60,9 +60,12 @@ import org.apache.hop.i18n.BaseMessages;
 import org.apache.hop.laf.BasePropertyHandler;
 import org.apache.hop.pipeline.PipelineMeta;
 import org.apache.hop.pipeline.PipelinePainter;
+import org.apache.hop.pipeline.transform.ITransformMeta;
+import org.apache.hop.pipeline.transform.TransformMeta;
 import org.apache.hop.ui.core.ConstUi;
 import org.apache.hop.ui.core.PropsUi;
 import org.apache.hop.ui.core.dialog.BaseDialog;
+import org.apache.hop.ui.core.dialog.EnterSelectionDialog;
 import org.apache.hop.ui.core.dialog.EnterTextDialog;
 import org.apache.hop.ui.core.dialog.ErrorDialog;
 import org.apache.hop.ui.core.dialog.MessageDialogWithToggle;
@@ -81,6 +84,7 @@ import org.apache.hop.ui.hopgui.dialog.NotePadDialog;
 import org.apache.hop.ui.hopgui.file.IHopFileType;
 import org.apache.hop.ui.hopgui.file.IHopFileTypeHandler;
 import org.apache.hop.ui.hopgui.file.delegates.HopGuiNotePadDelegate;
+import 
org.apache.hop.ui.hopgui.file.pipeline.context.HopGuiPipelineTransformContext;
 import org.apache.hop.ui.hopgui.file.shared.HopGuiTooltipExtension;
 import 
org.apache.hop.ui.hopgui.file.workflow.context.HopGuiWorkflowActionContext;
 import org.apache.hop.ui.hopgui.file.workflow.context.HopGuiWorkflowContext;
@@ -591,6 +595,11 @@ public class HopGuiWorkflowGraph extends 
HopGuiAbstractGraph
       if (areaOwner != null && areaOwner.getAreaType() != null) {
         switch (areaOwner.getAreaType()) {
           case ACTION_ICON:
+            if (shift && control) {
+              openReferencedObject();
+              return;
+            }
+
             ActionMeta actionCopy = (ActionMeta) areaOwner.getOwner();
             currentAction = actionCopy;
 
@@ -3281,28 +3290,30 @@ public class HopGuiWorkflowGraph extends 
HopGuiAbstractGraph
     fdTabFolder.left = new FormAttachment(0, 0);
     fdTabFolder.right = new FormAttachment(100, 0);
     fdTabFolder.top = new FormAttachment(0, 0);
-    fdTabFolder.bottom = new FormAttachment(100, 0);       
+    fdTabFolder.bottom = new FormAttachment(100, 0);
     extraViewTabFolder.setLayoutData(fdTabFolder);
 
     // Create toolbar for close and min/max to the upper right corner...
     //
     ToolBar extraViewToolBar = new ToolBar(extraViewTabFolder, SWT.FLAT);
-    extraViewTabFolder.setTopRight( extraViewToolBar, SWT.RIGHT );
+    extraViewTabFolder.setTopRight(extraViewToolBar, SWT.RIGHT);
     props.setLook(extraViewToolBar);
 
     minMaxItem = new ToolItem(extraViewToolBar, SWT.PUSH);
     minMaxItem.setImage(GuiResource.getInstance().getImageMaximizePanel());
-    minMaxItem.setToolTipText(BaseMessages.getString(PKG, 
"WorkflowGraph.ExecutionResultsPanel.MaxButton.Tooltip"));
+    minMaxItem.setToolTipText(
+        BaseMessages.getString(PKG, 
"WorkflowGraph.ExecutionResultsPanel.MaxButton.Tooltip"));
     minMaxItem.addListener(SWT.Selection, e -> minMaxExtraView());
-    
+
     closeItem = new ToolItem(extraViewToolBar, SWT.PUSH);
     closeItem.setImage(GuiResource.getInstance().getImageClosePanel());
-    closeItem.setToolTipText(BaseMessages.getString(PKG, 
"WorkflowGraph.ExecutionResultsPanel.CloseButton.Tooltip"));
+    closeItem.setToolTipText(
+        BaseMessages.getString(PKG, 
"WorkflowGraph.ExecutionResultsPanel.CloseButton.Tooltip"));
     closeItem.addListener(SWT.Selection, e -> disposeExtraView());
-        
+
     int height = extraViewToolBar.computeSize(SWT.DEFAULT, SWT.DEFAULT).y;
     extraViewTabFolder.setTabHeight(Math.max(height, 
extraViewTabFolder.getTabHeight()));
-    
+
     sashForm.setWeights(
         new int[] {
           60, 40,
@@ -3800,6 +3811,51 @@ public class HopGuiWorkflowGraph extends 
HopGuiAbstractGraph
     updateGui();
   }
 
+  @GuiKeyboardShortcut(key = 'z')
+  @GuiOsxKeyboardShortcut(key = 'z')
+  public void openReferencedObject() {
+    if (lastMove != null) {
+
+      // Hide the tooltip!
+      hideToolTips();
+
+      // Find the transform
+      ActionMeta action = workflowMeta.getAction(lastMove.x, lastMove.y, 
iconSize);
+      if (action != null) {
+        // Open referenced object...
+        //
+        IAction iAction = action.getAction();
+        String[] objectDescriptions = 
iAction.getReferencedObjectDescriptions();
+        if (objectDescriptions == null || objectDescriptions.length == 0) {
+          return;
+        }
+        // Only one reference?: open immediately
+        //
+        if (objectDescriptions.length == 1) {
+          HopGuiWorkflowActionContext.openReferencedObject(
+              workflowMeta, variables, iAction, objectDescriptions[0], 0);
+        } else {
+          // Show Selection dialog...
+          //
+          EnterSelectionDialog dialog =
+              new EnterSelectionDialog(
+                  getShell(),
+                  objectDescriptions,
+                  BaseMessages.getString(
+                      PKG, 
"HopGuiWorkflowGraph.OpenReferencedObject.Selection.Title"),
+                  BaseMessages.getString(
+                      PKG, 
"HopGuiWorkflowGraph.OpenReferencedObject.Selection.Message"));
+          String answer = dialog.open(0);
+          if (answer != null) {
+            int index = dialog.getSelectionNr();
+            HopGuiWorkflowActionContext.openReferencedObject(
+                workflowMeta, variables, iAction, answer, index);
+          }
+        }
+      }
+    }
+  }
+
   @Override
   public Object getSubject() {
     return workflowMeta;
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/context/HopGuiWorkflowActionContext.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/context/HopGuiWorkflowActionContext.java
index 4dd4dac..da94020 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/context/HopGuiWorkflowActionContext.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/context/HopGuiWorkflowActionContext.java
@@ -6,7 +6,7 @@
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *       http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -17,11 +17,13 @@
 
 package org.apache.hop.ui.hopgui.file.workflow.context;
 
+import org.apache.hop.core.Const;
 import org.apache.hop.core.file.IHasFilename;
 import org.apache.hop.core.gui.Point;
 import org.apache.hop.core.gui.plugin.action.GuiAction;
 import org.apache.hop.core.gui.plugin.action.GuiActionLambdaBuilder;
 import org.apache.hop.core.gui.plugin.action.GuiActionType;
+import org.apache.hop.core.variables.IVariables;
 import org.apache.hop.ui.core.dialog.ErrorDialog;
 import org.apache.hop.ui.hopgui.HopGui;
 import org.apache.hop.ui.hopgui.context.BaseGuiContextHandler;
@@ -86,10 +88,17 @@ public class HopGuiWorkflowActionContext extends 
BaseGuiContextHandler
                 "action-open-referenced-" + objectDescription,
                 GuiActionType.Info,
                 "open: " + objectDescription,
-                "This opens up the file referenced in the action",
+                "This opens up the file referenced in the action."
+                    + Const.CR
+                    + "You can hit key 'z' with the cursor over an Action icon 
or use CTRL+SHIFT+Click",
                 "ui/images/open.svg",
                 (shiftAction, controlAction, t) ->
-                    openReferencedObject(action, objectDescription, index));
+                    openReferencedObject(
+                        workflowMeta,
+                        workflowGraph.getVariables(),
+                        action,
+                        objectDescription,
+                        index));
         openReferencedAction.setCategory("Basic");
         openReferencedAction.setCategoryOrder("1");
         actions.add(openReferencedAction);
@@ -108,14 +117,18 @@ public class HopGuiWorkflowActionContext extends 
BaseGuiContextHandler
     return actions;
   }
 
-  private void openReferencedObject(IAction action, String objectDescription, 
int index) {
+  public static final void openReferencedObject(
+      WorkflowMeta workflowMeta,
+      IVariables variables,
+      IAction action,
+      String objectDescription,
+      int index) {
     HopGui hopGui = HopGui.getInstance();
     try {
       IHasFilename hasFilename =
-          action.loadReferencedObject(
-              index, workflowMeta.getMetadataProvider(), 
workflowGraph.getVariables());
+          action.loadReferencedObject(index, 
workflowMeta.getMetadataProvider(), variables);
       if (hasFilename != null) {
-        String filename = 
workflowGraph.getVariables().resolve(hasFilename.getFilename());
+        String filename = variables.resolve(hasFilename.getFilename());
 
         // Is this object already loaded?
         //
diff --git 
a/ui/src/main/resources/org/apache/hop/ui/hopgui/file/workflow/messages/messages_en_US.properties
 
b/ui/src/main/resources/org/apache/hop/ui/hopgui/file/workflow/messages/messages_en_US.properties
index b812c50..408463a 100644
--- 
a/ui/src/main/resources/org/apache/hop/ui/hopgui/file/workflow/messages/messages_en_US.properties
+++ 
b/ui/src/main/resources/org/apache/hop/ui/hopgui/file/workflow/messages/messages_en_US.properties
@@ -14,10 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-#File generated by Hop Translator for package 
'org.apache.hop.ui.hopgui.file.workflow' in locale 'en_US'
-#
-#
-#Sun Jan 10 17:43:54 CET 2021
 TransformPerformanceSnapShotDialog.Input=Input
 HopGui.StringSearchResult.Title=Results of search
 HopGui.Message.Warning.Cancel=Cancel
@@ -1032,12 +1028,10 @@ WorkflowGraph.Toolbar.AlignBottom.Tooltip=Align the 
actions with the bottom-most
 WorkflowGraph.Toolbar.DistributeHorizontal.Tooltip=Distribute the selected 
actions evenly between the left-most and right-most action in your selection
 WorkflowGraph.Toolbar.DistributeVertical.Tooltip=Distribute the selected 
actions evenly between the top-most and bottom-most action in your selection
 WorkflowGraph.Toolbar.EditWorkflow.Tooltip=Edit workflow properties (CTRL-L or 
CMD-L)
-
 HopGuiWorkflowGraph.ContextualActionDialog.Workflow.Header=Select the action 
to execute or the action to create:
 HopGuiWorkflowGraph.ContextualActionDialog.Action.Header=Select the action to 
take on action ''{0}'':
 HopGuiWorkflowGraph.ContextualActionDialog.Note.Header=Select the note action 
to take:
 HopGuiWorkflowGraph.ContextualActionDialog.Hop.Header=Select the hop action to 
take:
-
 HopGuiWorkflowGraph.ContextualAction.Category.Basic.Text=Basic
 HopGuiWorkflowGraph.ContextualAction.Category.Advanced.Text=Advanced
 HopGuiWorkflowGraph.ContextualAction.Category.Routing.Text=Routing
@@ -1086,13 +1080,14 @@ 
HopGuiWorkflowGraph.ErrorDialog.FileNotLoaded.Header=Error
 HopGuiWorkflowGraph.ErrorDialog.FileNotLoaded.Message=The referenced file 
couldn''t be loaded
 HopGuiWorkflowGraph.ErrorDialog.WorkflowDrawing.Header=Error
 HopGuiWorkflowGraph.ErrorDialog.WorkflowDrawing.Message=Error drawing workflow
-
 HopWorkflowFileType.New.Text=New workflow
 HopWorkflowFileType.GuiAction.Workflow.Name=Workflow
 HopWorkflowFileType.GuiAction.Workflow.Tooltip=Creates a workflow: a 
sequential set of actions where a path is followed based on the outcome of 
executions and conditions.
 HopWorkflowFileType.ErrorDialog.NewWorkflowCreation.Header=Error
 HopWorkflowFileType.ErrorDialog.NewWorkflowCreation.Message=Error creating new 
workflow
-
 PipelineGraph.NewWorkflowBackgroundMessage=Left click or tap anywhere to start.
 HopGuiWorkflowGraph.SaveFile.Dialog.Header=Save File?
-HopGuiWorkflowGraph.SaveFile.Dialog.Message=Do you want to save file ''{0}'' 
before closing?
\ No newline at end of file
+HopGuiWorkflowGraph.SaveFile.Dialog.Message=Do you want to save file ''{0}'' 
before closing?
+HopGuiWorkflowGraph.OpenReferencedObject.Selection.Title=Open referenced file
+HopGuiWorkflowGraph.OpenReferencedObject.Selection.Message=Select the 
referenced file to open:
+
diff --git 
a/ui/src/main/resources/org/apache/hop/ui/hopgui/messages/messages_en_US.properties
 
b/ui/src/main/resources/org/apache/hop/ui/hopgui/messages/messages_en_US.properties
index 68a3b74..de66c19 100644
--- 
a/ui/src/main/resources/org/apache/hop/ui/hopgui/messages/messages_en_US.properties
+++ 
b/ui/src/main/resources/org/apache/hop/ui/hopgui/messages/messages_en_US.properties
@@ -1,5 +1,4 @@
 #
-#
 # Licensed to the Apache Software Foundation (ASF) under one or more
 # contributor license agreements.  See the NOTICE file distributed with
 # this work for additional information regarding copyright ownership.
@@ -15,8 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-#
-#
 HopGui.Menu.File.ExportToSVG=Export to SVG
 HopGui.Menu.Edit.Undo=Undo
 HopGui.Menu.Edit.Redo=Redo
@@ -34,7 +31,6 @@ HopGui.Menu.Run.Debug=Debug
 HopGui.Menu.Tools.EditConfigVariables=Edit config variables...
 HopGui.Menu.Tools.DatabaseClearCache=Clear databases cache
 HopGui.Menu.Help.About=About...
-
 TransformPerformanceSnapShotDialog.Input=Input
 HopGui.StringSearchResult.Title=Results of search
 HopGui.Message.Warning.Cancel=Cancel
@@ -975,21 +971,22 @@ PipelineHistory.Column.Read=Read
 HopGui.Dialog.PromptSave.Message=File ''{0}'' has changed.  Do you want to 
save it?
 HopGui.Toolbar.Undo.Tooltip=Undo an operation
 HopGui.Toolbar.Redo.Tooltip=Redo an operation
-HopGui.Toolbar.Zoom=  Zoom: 
+HopGui.Toolbar.Zoom=Zoom: 
 HopGui.Toolbar.Zoom.Tooltip=Zoom in our out
 HopGui.Toolbar.EditProperties.Tooltip=Edit the pipeline properties (CTRL-T or 
CMD-T)
 PipelineGraph.NewPipelineBackgroundMessage=Left click or tap anywhere to start.
 PipelineGraph.SaveFile.Dialog.Header=Save File?
 PipelineGraph.SaveFile.Dialog.Message=Do you want to save file ''{0}'' before 
closing?
-
-
 PipelineGraph.ContextualActionDialog.Pipeline.Header=Select the action to 
execute or the transform to create:
 PipelineGraph.ContextualActionDialog.Transform.Header=Select the action to 
take on transform ''{0}'':
 PipelineGraph.ContextualActionDialog.Note.Header=Select the note action to 
take:
 PipelineGraph.ContextualActionDialog.Hop.Header=Select the hop action to take:
-
 PipelineGraph.ViewOutput.OutputDialog.Header=Output of {0}
 PipelineGraph.ViewOutput.OutputDialog.OutputRows.Text=output rows of transform 
{0}
 PipelineGraph.ViewOutput.OutputDialog.First.Text=First 
 PipelineGraph.ViewOutput.OutputDialog.Last.Text=Last (REVERSE ORDER!) 
 PipelineGraph.ViewOutput.OutputDialog.Random.Text=Random 
+HopGuiPipelineGraph.OpenReferencedObject.Selection.Title=Open referenced file
+HopGuiPipelineGraph.OpenReferencedObject.Selection.Message=Select the 
referenced file to open:
+
+

Reply via email to