sramazzina commented on pull request #1215: URL: https://github.com/apache/incubator-hop/pull/1215#issuecomment-989648566
Ciao Hans, as you said, the original transform's code basically did nothing. After my changes, I fixed the problem and if the checkbox _"Do not report any error on no files or folders"_ is unchecked, the transform just print a message at the error level in the Hop console log to inform that no files where found. In my opinion we can also take the log level for that message to basic because it is just an information message and nothing more. I also changed the message printer originally that in my opinion was wrong from logical point of view (becaue the label just says _not report any error_ and not that the process had to be stopped). On the other side, because of the accessor's name, I thought it was a good idea to add a further option (enabled only when the checkbox mentioned above is unset) to enforce an error condition and raise an exception if we have no files. Initially, I wanted also to fix the names of the accessors and variable with a more meaningful name but then I decided not to do that because we were at risk to introduce a misunderstanding between the name of the metadata element (that had to remain the same) and the name of the internal accessor because they were different. In this case, I found it was a good idea that the error message was the original messave with the phrase _stop processing_ in it. About the integration tests, you are right I've not pushed any test, my bad. I can build an integration test to test the good processing and another one to test the new option (the raise of the exception in case no files were found). I hope I was able to answer adequately to your doubts :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
