hansva commented on pull request #1215: URL: https://github.com/apache/incubator-hop/pull/1215#issuecomment-989843168
Thanks for the clarification @sramazzina, I thought I was missing something when going through that original code and it was some special feature, glad to know you also noticed it does not work. As we are now reaching a more stable codebase and going top level project I am tightening the screws a bit on quality of pull requests. I will do a proposal to the dev list soon containing an updated checklist that we can add in our pull request template but I think our goal should be: - Clear description in Jira on what we are doing and why (can be used for release notes of a new version) - General code quality (we are already good on this point) - Integration tests for all new features - Up to date documentation In this case we need an update of the docs too, describe what the old flag does now and add documentation for the new flag and also add some integration tests and this PR is good to be merged. Cheers, Hans -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
