[hop] branch master updated: HOP-3980 Hidden ClassCastException in TableView

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new a880afa1fd HOP-3980 Hidden ClassCastException in TableView
     new 5d7bb18e90 Merge pull request #1527 from nadment/HOP-3980
a880afa1fd is described below

commit a880afa1fd2557cea6e14496fb540232d10e02c8
Author: Nicolas Adment <nadm...@gmail.com>
AuthorDate: Mon Jun 6 17:49:35 2022 +0200

    HOP-3980 Hidden ClassCastException in TableView
---
 .../testing/src/main/java/org/apache/hop/ui/testing/EditRowsDialog.java | 2 +-
 ui/src/main/java/org/apache/hop/ui/core/dialog/PreviewRowsDialog.java   | 2 +-
 ui/src/main/java/org/apache/hop/ui/core/widget/TableView.java           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/plugins/misc/testing/src/main/java/org/apache/hop/ui/testing/EditRowsDialog.java
 
b/plugins/misc/testing/src/main/java/org/apache/hop/ui/testing/EditRowsDialog.java
index 5cc5b898ad..cda7c5cdaf 100644
--- 
a/plugins/misc/testing/src/main/java/org/apache/hop/ui/testing/EditRowsDialog.java
+++ 
b/plugins/misc/testing/src/main/java/org/apache/hop/ui/testing/EditRowsDialog.java
@@ -255,7 +255,7 @@ public class EditRowsDialog {
     String strNr;
     lineNr++;
     try {
-      strNr = wFields.getNumberColumn().getValueMeta().getString(new 
Long(lineNr));
+      strNr = 
wFields.getNumberColumn().getValueMeta().getString(Long.valueOf(lineNr));
     } catch (Exception e) {
       strNr = Integer.toString(lineNr);
     }
diff --git 
a/ui/src/main/java/org/apache/hop/ui/core/dialog/PreviewRowsDialog.java 
b/ui/src/main/java/org/apache/hop/ui/core/dialog/PreviewRowsDialog.java
index 583033ac6d..844141041d 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/dialog/PreviewRowsDialog.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/dialog/PreviewRowsDialog.java
@@ -355,7 +355,7 @@ public class PreviewRowsDialog {
     String strNr;
     lineNr++;
     try {
-      strNr = wFields.getNumberColumn().getValueMeta().getString(new 
Long(lineNr));
+      strNr = 
wFields.getNumberColumn().getValueMeta().getString(Long.valueOf(lineNr));
     } catch (Exception e) {
       strNr = Integer.toString(lineNr);
     }
diff --git a/ui/src/main/java/org/apache/hop/ui/core/widget/TableView.java 
b/ui/src/main/java/org/apache/hop/ui/core/widget/TableView.java
index d5e4ca19b4..8a58adc9c9 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/widget/TableView.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/widget/TableView.java
@@ -278,7 +278,7 @@ public class TableView extends Composite {
     clearUndo();
 
     numberColumn = new ColumnInfo("#", ColumnInfo.COLUMN_TYPE_TEXT, true, 
true);
-    IValueMeta numberColumnValueMeta = new ValueMetaNumber("#");
+    IValueMeta numberColumnValueMeta = new ValueMetaString("#");
     numberColumnValueMeta.setConversionMask("####0.###");
     numberColumn.setValueMeta(numberColumnValueMeta);