This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 43d5c3d620 HOP-3981 Fix position and size of the 
AREA_DRAWN_GOLDEN_DATA_SET is not correct
     new 9df65ab496 Merge pull request #1528 from nadment/HOP-3981
43d5c3d620 is described below

commit 43d5c3d620413aab03ef9ebc9d838966238d6f56
Author: Nicolas Adment <[email protected]>
AuthorDate: Mon Jun 6 23:13:58 2022 +0200

    HOP-3981 Fix position and size of the AREA_DRAWN_GOLDEN_DATA_SET is not
    correct
---
 .../testing/xp/DrawGoldenDataSetOnTransformExtensionPoint.java | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/DrawGoldenDataSetOnTransformExtensionPoint.java
 
b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/DrawGoldenDataSetOnTransformExtensionPoint.java
index da4fe12ef0..12a125bc3a 100644
--- 
a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/DrawGoldenDataSetOnTransformExtensionPoint.java
+++ 
b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/DrawGoldenDataSetOnTransformExtensionPoint.java
@@ -73,9 +73,6 @@ public class DrawGoldenDataSetOnTransformExtensionPoint
     // Now we're here, draw a marker and indicate the name of the unit test
     //
     IGc gc = ext.gc;
-    int iconSize = ext.iconSize;
-    int x = ext.x1;
-    int y = ext.y1;
 
     gc.setLineWidth(transformMeta.isSelected() ? 2 : 1);
     gc.setForeground(IGc.EColor.CRYSTAL);
@@ -88,7 +85,7 @@ public class DrawGoldenDataSetOnTransformExtensionPoint
     // Draw it at the right hand side
     //
     int arrowSize = textExtent.y;
-    Point point = new Point(x + iconSize, y + (iconSize - textExtent.y) / 2);
+    Point point = new Point(ext.x1 + ext.iconSize, ext.y1 + (ext.iconSize - 
textExtent.y) / 2);
 
     int[] arrow =
         new int[] {
@@ -115,9 +112,9 @@ public class DrawGoldenDataSetOnTransformExtensionPoint
             AreaOwner.AreaType.CUSTOM,
             point.x,
             point.y,
-            textExtent.x,
+            textExtent.x + arrowSize,
             textExtent.y,
-            new Point(0, 0),
+            ext.offset,
             DataSetConst.AREA_DRAWN_GOLDEN_DATA_SET,
             transformMeta.getName()));
 
@@ -155,3 +152,4 @@ public class DrawGoldenDataSetOnTransformExtensionPoint
     }
   }
 }
+

Reply via email to