scali commented on code in PR #1540:
URL: https://github.com/apache/hop/pull/1540#discussion_r901633199


##########
helm/hop-server/values.yaml:
##########
@@ -19,15 +19,30 @@
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 
+## @param replicaCount number of replicas for the statefulset
 replicaCount: 1
 
+## @section Image
+## @param image.name Image name
+## @param image.pullPolicy Image pull policy
+## @param image.tag Visit: [Image 
tag](https://hub.docker.com/r/apache/hop/tags?page=1&ordering=last_updated)
+## @param image.env Environment variables
 image:
   name: docker.io/apache/hop
   pullPolicy: IfNotPresent
-  # Overrides the image tag whose default is the chart appVersion.
-  tag: "1.0-SNAPSHOT"
+  # Overrides the image tag
+  tag: "1.2.0"

Review Comment:
   Yes, that could be a pretty nice solution to publish the chart packaged to 
one of the helm repositories that exists. But I don't know central authority 
for Helm, only kind of private initiative (bitnami, oteemo...), or site-level 
repository (eg : [Apache 
Airflow](https://airflow.apache.org/docs/helm-chart/stable/index.html), [Gitea 
Chart](https://dl.gitea.io/charts/)).
   
   Maybe the example of the ASF project Apache Airflow could be the simplest to 
implement ? Should I write this suggestion to a JIRA issue ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to