[hop] branch 2185 updated: PostgreSQL supports boolean and timestamp data type #2185

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch 2185
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/2185 by this push:
     new 51e7cf8f27 PostgreSQL supports boolean and timestamp data type #2185
     new 844f362e98 Merge pull request #2188 from nadment/2185
51e7cf8f27 is described below

commit 51e7cf8f27f25bd756b84c887bb7a04f1904da38
Author: Nicolas Adment <39568358+nadm...@users.noreply.github.com>
AuthorDate: Mon Jan 23 22:42:02 2023 +0100

    PostgreSQL supports boolean and timestamp data type #2185
---
 .../hop/databases/postgresql/PostgreSqlDatabaseMeta.java       | 10 ++++++++++
 .../hop/databases/postgresql/PostgreSqlDatabaseMetaTest.java   |  4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git 
a/plugins/databases/postgresql/src/main/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMeta.java
 
b/plugins/databases/postgresql/src/main/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMeta.java
index 2a736be3cc..53c22da8c3 100644
--- 
a/plugins/databases/postgresql/src/main/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMeta.java
+++ 
b/plugins/databases/postgresql/src/main/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMeta.java
@@ -1077,6 +1077,16 @@ public class PostgreSqlDatabaseMeta extends 
BaseDatabaseMeta implements IDatabas
     return true;
   }
 
+  @Override
+  public boolean isSupportsBooleanDataType() {   
+    return true;
+  }
+  
+  @Override
+  public boolean isSupportsTimestampDataType() {
+    return true;
+  }  
+
   @Override
   public boolean isSupportsGetBlob() {
     return false;
diff --git 
a/plugins/databases/postgresql/src/test/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMetaTest.java
 
b/plugins/databases/postgresql/src/test/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMetaTest.java
index a36f7f4074..5f79cdd2bb 100644
--- 
a/plugins/databases/postgresql/src/test/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMetaTest.java
+++ 
b/plugins/databases/postgresql/src/test/java/org/apache/hop/databases/postgresql/PostgreSqlDatabaseMetaTest.java
@@ -704,6 +704,8 @@ public class PostgreSqlDatabaseMetaTest {
     assertTrue(nativeMeta.isRequiresCastToVariousForIsNull());
     assertFalse(nativeMeta.isSupportsGetBlob());
     assertTrue(nativeMeta.isUseSafePoints());
+    assertTrue(nativeMeta.isSupportsBooleanDataType());
+    assertTrue(nativeMeta.isSupportsTimestampDataType());
   }
 
   @Test
@@ -730,7 +732,7 @@ public class PostgreSqlDatabaseMetaTest {
             "FOO", new ValueMetaTimestamp("BAR"), "", false, "", false));
 
     assertEquals(
-        "ALTER TABLE FOO ADD COLUMN BAR CHAR(1)",
+        "ALTER TABLE FOO ADD COLUMN BAR BOOLEAN",
         nativeMeta.getAddColumnStatement("FOO", new ValueMetaBoolean("BAR"), 
"", false, "", false));
 
     assertEquals(