[hop] branch master updated: Only list fake data types that work, fixes #2405

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 09d2a38083 Only list fake data types that work, fixes #2405
     new 81c3484bf6 Merge pull request #2895 from hansva/master
09d2a38083 is described below

commit 09d2a3808313f0bd8c49d497dbdcbcc85331ca3d
Author: Hans Van Akelyen <hans.van.akel...@gmail.com>
AuthorDate: Tue May 2 14:31:34 2023 +0200

    Only list fake data types that work, fixes #2405
---
 .../apache/hop/pipeline/transforms/fake/FakeDialog.java | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git 
a/plugins/transforms/fake/src/main/java/org/apache/hop/pipeline/transforms/fake/FakeDialog.java
 
b/plugins/transforms/fake/src/main/java/org/apache/hop/pipeline/transforms/fake/FakeDialog.java
index 2eb4f98e79..acf8bc703d 100644
--- 
a/plugins/transforms/fake/src/main/java/org/apache/hop/pipeline/transforms/fake/FakeDialog.java
+++ 
b/plugins/transforms/fake/src/main/java/org/apache/hop/pipeline/transforms/fake/FakeDialog.java
@@ -17,6 +17,9 @@
 
 package org.apache.hop.pipeline.transforms.fake;
 
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.List;
 import org.apache.hop.core.Const;
 import org.apache.hop.core.util.Utils;
 import org.apache.hop.core.variables.IVariables;
@@ -42,9 +45,6 @@ import org.eclipse.swt.widgets.Shell;
 import org.eclipse.swt.widgets.TableItem;
 import org.eclipse.swt.widgets.Text;
 
-import java.lang.reflect.Method;
-import java.util.List;
-
 public class FakeDialog extends BaseTransformDialog implements 
ITransformDialog {
   private static final Class<?> PKG = FakeDialog.class; // For Translator
 
@@ -198,10 +198,15 @@ public class FakeDialog extends BaseTransformDialog 
implements ITransformDialog
   public String[] getMethodNames(FakerType fakerType) {
     try {
       Method[] methods = fakerType.getFakerClass().getDeclaredMethods();
-      String[] names = new String[methods.length];
-      for (int i = 0; i < names.length; i++) {
-        names[i] = methods[i].getName();
+      ArrayList<String> tempNames = new ArrayList<>();
+      for (Method method : methods) {
+        // ignore Methods needing parameters for now
+        if (method.getParameterCount() == 0) {
+          tempNames.add(method.getName());
+        }
       }
+      String[] names = new String[tempNames.size()];
+      tempNames.toArray(names);
       return names;
     } catch (Exception e) {
       return new String[] {};