[hop] branch master updated: mongoDb Delete widget disposed error and enable test, fixes #2971

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 2fea38dcfa mongoDb Delete widget disposed error and enable test, fixes 
#2971
     new 341ba53739 Merge pull request #3076 from 
hansva/#2971-mongodb-widget-disposed
2fea38dcfa is described below

commit 2fea38dcfaa9991dfd06939d172d1155afd86bb6
Author: Hans Van Akelyen <hans.van.akel...@gmail.com>
AuthorDate: Wed Jul 12 10:27:27 2023 +0200

    mongoDb Delete widget disposed error and enable test, fixes #2971
---
 .../hopweb/src/test/resources/transforms.csv        |  1 +
 .../mongodbdelete/MongoDbDeleteDialog.java          | 21 +++------------------
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/integration-tests/hopweb/src/test/resources/transforms.csv 
b/integration-tests/hopweb/src/test/resources/transforms.csv
index a109d08d12..f56c624377 100644
--- a/integration-tests/hopweb/src/test/resources/transforms.csv
+++ b/integration-tests/hopweb/src/test/resources/transforms.csv
@@ -129,6 +129,7 @@ Microsoft Access output
 Microsoft Excel input
 Microsoft Excel writer
 MonetDB bulk loader
+MongoDB Delete
 MongoDB input
 MongoDB output
 Multiway merge join
diff --git 
a/plugins/transforms/mongodb/src/main/java/org/apache/hop/pipeline/transforms/mongodbdelete/MongoDbDeleteDialog.java
 
b/plugins/transforms/mongodb/src/main/java/org/apache/hop/pipeline/transforms/mongodbdelete/MongoDbDeleteDialog.java
index 8b751f3808..6c8facb9ae 100644
--- 
a/plugins/transforms/mongodb/src/main/java/org/apache/hop/pipeline/transforms/mongodbdelete/MongoDbDeleteDialog.java
+++ 
b/plugins/transforms/mongodb/src/main/java/org/apache/hop/pipeline/transforms/mongodbdelete/MongoDbDeleteDialog.java
@@ -18,6 +18,9 @@
 package org.apache.hop.pipeline.transforms.mongodbdelete;
 
 import com.mongodb.DBObject;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
 import org.apache.commons.lang.StringUtils;
 import org.apache.hop.core.Const;
 import org.apache.hop.core.Props;
@@ -56,8 +59,6 @@ import org.eclipse.swt.custom.CTabItem;
 import org.eclipse.swt.events.ModifyListener;
 import org.eclipse.swt.events.SelectionAdapter;
 import org.eclipse.swt.events.SelectionEvent;
-import org.eclipse.swt.events.ShellAdapter;
-import org.eclipse.swt.events.ShellEvent;
 import org.eclipse.swt.layout.FormAttachment;
 import org.eclipse.swt.layout.FormData;
 import org.eclipse.swt.layout.FormLayout;
@@ -69,10 +70,6 @@ import org.eclipse.swt.widgets.Shell;
 import org.eclipse.swt.widgets.TableItem;
 import org.eclipse.swt.widgets.Text;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Set;
-
 /** Dialog class for MongoDbDelete step */
 public class MongoDbDeleteDialog extends BaseTransformDialog implements 
ITransformDialog {
 
@@ -84,10 +81,7 @@ public class MongoDbDeleteDialog extends BaseTransformDialog 
implements ITransfo
   private Button wbGetFields;
   private Button wbPreviewDocStruct;
   private CCombo wCollection;
-//  private CCombo wcbWriteConcern;
   private TextVar wtvTimeout;
-//  private Button wcbJournalWritesCheck;
-//  private CCombo wcbReadPreference;
   private TextVar wtvWriteRetries;
   private TextVar wtvWriteRetryDelay;
   private TableView wtvMongoFieldsView;
@@ -495,15 +489,6 @@ public class MongoDbDeleteDialog extends 
BaseTransformDialog implements ITransfo
 
     wTransformName.addListener(SWT.Selection, e -> ok());
 
-    // Detect X or ALT-F4 or something that kills this window...
-    shell.addShellListener(
-        new ShellAdapter() {
-          @Override
-          public void shellClosed(ShellEvent e) {
-            cancel();
-          }
-        });
-
     wTabFolder.setSelection(0);
     setSize();