[hop] branch master updated: ExcelWriterTransform: POI temporary files are not disposed in streaming mode

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new 506c7fcd34 ExcelWriterTransform: POI temporary files are not disposed 
in streaming mode
     new 54330c0185 Merge pull request #3211 from Mgiepz/master
506c7fcd34 is described below

commit 506c7fcd34a91a01675c59dee81e89ed8c0dd202
Author: m.giepz <marius.gi...@epg.com>
AuthorDate: Thu Sep 7 12:53:25 2023 +0200

    ExcelWriterTransform: POI temporary files are not disposed in streaming mode
---
 .../hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java   | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git 
a/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
 
b/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
index f6af1d4ca5..9e33135120 100644
--- 
a/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
+++ 
b/plugins/transforms/excel/src/main/java/org/apache/hop/pipeline/transforms/excelwriter/ExcelWriterTransform.java
@@ -328,6 +328,12 @@ public class ExcelWriterTransform
       // This closes the output stream as well
       file.getWorkbook().write(out);
       file.getWorkbook().close();
+
+      // deleting the temporary files
+      if (file.getWorkbook() instanceof SXSSFWorkbook ) {
+        ((SXSSFWorkbook ) file.getWorkbook()).dispose();
+      }
+
     } catch (IOException e) {
       throw new HopException(e);
     } finally {