This is an automated email from the ASF dual-hosted git repository.

mcasters pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new a2f778dfa0 Update filterrows.adoc
     new 3b8d5eaede Merge pull request #3351 from Mattang-Dan/patch-36
a2f778dfa0 is described below

commit a2f778dfa0b935d2baab8c3aa7902fb67cae5824
Author: Mattang-Dan <[email protected]>
AuthorDate: Fri Nov 3 13:45:51 2023 -0700

    Update filterrows.adoc
    
    re-organized first few paragraphs, and removed redundant information.
---
 .../ROOT/pages/pipeline/transforms/filterrows.adoc     | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git 
a/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/filterrows.adoc 
b/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/filterrows.adoc
index c085c71e54..494b3588ec 100644
--- 
a/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/filterrows.adoc
+++ 
b/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/filterrows.adoc
@@ -70,16 +70,8 @@ TIP: Lists also works on numeric values like integers. In 
this case, the list of
 
 The filter rows transform detects only fields in the input stream.
 
-The filter rows transform detects only fields in the input stream. If you want 
to filter rows based on a variable value, you can modify the previous 
transform. For example, a table input transform can include the variable in the 
SQL as another field such as
-[source,sql]
-----
-SELECT field1, field2, ${myvar} AS field3 FROM table1
-----
-, then in the filter row condition you can say field1 = field3. Alternatively, 
you can use a ‘Get Variables’ transform to set parameters in fields.
-
-You can use a REGEX expression in the "filter row" transform.  
-
-A query:
+The filter rows transform detects only fields in the input stream. If you want 
to filter rows based on a variable value, you can modify the previous 
transform. 
+For example, a table input transform can include the variable in the SQL as 
another field such as shown below. Alternatively, you can use a ‘Get Variables’ 
transform to set parameters in fields.
 
 [source,sql]
 ----
@@ -90,14 +82,16 @@ FROM table
 WHERE field1=xxxx
 ----
 
-Then in the filter row condition, you can have
+Then in the filter row condition, you can have:
 
 [source,bash]
 ----
 field1 = field3
 ----
 
-*FYI* - instead of the Table Input trick above you can use the simple "Get 
Variables" transform to set parameters in fields.
+*FYI* - instead of adding a field to the Table Input shown above, you can also 
use a "Get Variables" transform to set fields.
+
+TIP: You can use a REGEX expression in the "filter row" transform.  
 
 Remember that all transforms are executed in parallel, so both true and false 
paths will run in some cases. 
 In some cases it will be better to use a where filter in a SQL query than use 
a Filter rows transform. If you need to return input rows for either case 
(true/false), you can use various SQL query methods that will always return 
results using IF EXISTS or IS NULL for example.

Reply via email to