This is an automated email from the ASF dual-hosted git repository.

nadment pushed a commit to branch 4124
in repository https://gitbox.apache.org/repos/asf/hop.git

commit 812e05a02f59ed3228281ecab905a1e429fd4b76
Author: Nicolas Adment <[email protected]>
AuthorDate: Sat Jul 13 19:04:09 2024 +0200

    The layout of the Write to log action is bad #4124
---
 .../workflow/actions/writetolog/ActionWriteToLogDialog.java |  5 ++---
 .../actions/writetolog/messages/messages_de_DE.properties   | 10 +++++-----
 .../actions/writetolog/messages/messages_en_US.properties   | 13 ++++++-------
 .../actions/writetolog/messages/messages_es_AR.properties   |  1 -
 .../actions/writetolog/messages/messages_fr_FR.properties   | 13 ++++++-------
 .../actions/writetolog/messages/messages_it_IT.properties   | 10 +++++-----
 .../actions/writetolog/messages/messages_ja_JP.properties   |  7 +++----
 .../actions/writetolog/messages/messages_ko_KR.properties   |  7 +++----
 .../actions/writetolog/messages/messages_nl_NL.properties   |  1 -
 .../actions/writetolog/messages/messages_pt_BR.properties   | 13 ++++++-------
 .../actions/writetolog/messages/messages_zh_CN.properties   |  2 +-
 11 files changed, 37 insertions(+), 45 deletions(-)

diff --git 
a/plugins/actions/writetolog/src/main/java/org/apache/hop/workflow/actions/writetolog/ActionWriteToLogDialog.java
 
b/plugins/actions/writetolog/src/main/java/org/apache/hop/workflow/actions/writetolog/ActionWriteToLogDialog.java
index 802fbbdb0c..399d3d21ce 100644
--- 
a/plugins/actions/writetolog/src/main/java/org/apache/hop/workflow/actions/writetolog/ActionWriteToLogDialog.java
+++ 
b/plugins/actions/writetolog/src/main/java/org/apache/hop/workflow/actions/writetolog/ActionWriteToLogDialog.java
@@ -99,13 +99,13 @@ public class ActionWriteToLogDialog extends ActionDialog {
     wCancel.addListener(SWT.Selection, e -> cancel());
     BaseTransformDialog.positionBottomButtons(shell, new Button[] {wOk, 
wCancel}, margin, null);
 
-    // Filename line
+    // Action name
     Label wlName = new Label(shell, SWT.RIGHT);
     wlName.setText(BaseMessages.getString(PKG, "WriteToLog.ActionName.Label"));
     PropsUi.setLook(wlName);
     FormData fdlName = new FormData();
     fdlName.left = new FormAttachment(0, 0);
-    fdlName.right = new FormAttachment(middle, 0);
+    fdlName.right = new FormAttachment(middle, -margin);
     fdlName.top = new FormAttachment(0, margin);
     wlName.setLayoutData(fdlName);
     wName = new Text(shell, SWT.SINGLE | SWT.LEFT | SWT.BORDER);
@@ -135,7 +135,6 @@ public class ActionWriteToLogDialog extends ActionDialog {
     fdLoglevel.right = new FormAttachment(100, 0);
     wLoglevel.setLayoutData(fdLoglevel);
 
-    // Subject
     // Log subject
     Label wlLogSubject = new Label(shell, SWT.RIGHT);
     wlLogSubject.setText(BaseMessages.getString(PKG, 
"WriteToLog.LogSubject.Label"));
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_de_DE.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_de_DE.properties
index d36c3c9989..76f9fb6793 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_de_DE.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_de_DE.properties
@@ -25,8 +25,8 @@ WriteToLog.ActionName.Label=Action Name
 WriteToLog.Error.Description=Folgender Fehler trat auf
 WriteToLog.Error.Label=ERROR
 WriteToLog.Error.UnableToLoadFromXML.Label=Konnte Action "Schreibe ins Log" 
nicht aus XML laden
-WriteToLog.Loglevel.Label=Log level 
-WriteToLog.LogMessage.Label=Log Nachricht    
-WriteToLog.LogSubject.Label=Logging Thema   
-WriteToLog.Name.Default=Write to log 
-WriteToLog.Title=Write to log 
+WriteToLog.Loglevel.Label=Log level
+WriteToLog.LogMessage.Label=Log Nachricht
+WriteToLog.LogSubject.Label=Logging Thema
+WriteToLog.Name.Default=Write to log
+WriteToLog.Title=Write to log
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_en_US.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_en_US.properties
index 735fed40fd..5def442361 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_en_US.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_en_US.properties
@@ -21,12 +21,11 @@
 ActionWriteToLog.Description=Write message to log
 ActionWriteToLog.keyword=write,log
 ActionWriteToLog.Name=Write to log
-WriteToLog.ActionName.Label=Action name 
+WriteToLog.ActionName.Label=Action name
 WriteToLog.Error.Description=The following error occurred
 WriteToLog.Error.Label=ERROR
-WriteToLog.Error.UnableToLoadFromXML.Label=Unable to load action of type 
'Write to log' from XML node
-WriteToLog.Loglevel.Label=Log level 
-WriteToLog.LogMessage.Label=Log message    
-WriteToLog.LogSubject.Label=Log subject   
-WriteToLog.Name.Default=Write to log 
-WriteToLog.Title=Write to log 
+WriteToLog.Loglevel.Label=Log level
+WriteToLog.LogMessage.Label=Log message
+WriteToLog.LogSubject.Label=Log subject
+WriteToLog.Name.Default=Write to log
+WriteToLog.Title=Write to log
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_es_AR.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_es_AR.properties
index b53ccec1ec..43094cead5 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_es_AR.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_es_AR.properties
@@ -22,7 +22,6 @@ ActionWriteToLog.Name=Escribir al log
 WriteToLog.ActionName.Label=Nombre de la entrada de trabajo
 WriteToLog.Error.Description=Ocurri\u00F3 el siguiente error
 WriteToLog.Error.Label=ERROR
-WriteToLog.Error.UnableToLoadFromXML.Label=\ No se puede cargar la entrada de 
trabajo del tipo 'Escribir al registro' del nodo XML
 WriteToLog.Loglevel.Label=Nivel de registro
 WriteToLog.LogMessage.Label=Mensaje de registro
 WriteToLog.LogSubject.Label=Asunto del registro
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_fr_FR.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_fr_FR.properties
index 6712045021..ed42042a6d 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_fr_FR.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_fr_FR.properties
@@ -20,12 +20,11 @@
 
 ActionWriteToLog.Description=Ecriture de message dans la trace de l'action
 ActionWriteToLog.Name=Ecriture dans trace
-WriteToLog.ActionName.Label=Nom de l''action 
-WriteToLog.Error.Description=Apache Hop a rencontr\u00E9 l''erreur suivante  
+WriteToLog.ActionName.Label=Nom de l''action
+WriteToLog.Error.Description=Apache Hop a rencontr\u00E9 l''erreur suivante
 WriteToLog.Error.Label=ERREUR
-WriteToLog.Error.UnableToLoadFromXML.Label=Impossible de charger depuis le 
fichier XML, l''action 'Ecrire dans la trace'
-WriteToLog.Loglevel.Label=Niveau trace 
-WriteToLog.LogMessage.Label=Message \u00E0 \u00E9crire 
+WriteToLog.Loglevel.Label=Niveau trace
+WriteToLog.LogMessage.Label=Message \u00E0 \u00E9crire
 WriteToLog.LogSubject.Label=Titre \u00E0 \u00E9crire
-WriteToLog.Name.Default=Ecriture dans la trace 
-WriteToLog.Title=Ecriture dans la trace 
+WriteToLog.Name.Default=Ecriture dans la trace
+WriteToLog.Title=Ecriture dans la trace
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_it_IT.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_it_IT.properties
index 180a8a4175..d0637ed656 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_it_IT.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_it_IT.properties
@@ -23,8 +23,8 @@ WriteToLog.ActionName.Label=Nome action
 WriteToLog.Error.Description=Si \u00E8 verificato il seguente errore
 WriteToLog.Error.Label=ERRORE
 WriteToLog.Error.UnableToLoadFromXML.Label=Impossibile caricare action di tipo 
'Write to log' dal nodo XML
-WriteToLog.Loglevel.Label=Livello di log 
-WriteToLog.LogMessage.Label=Messaggio di log 
-WriteToLog.LogSubject.Label=Oggetto del log 
-WriteToLog.Name.Default=Scrivi nel log 
-WriteToLog.Title=Scrivi nel log 
+WriteToLog.Loglevel.Label=Livello di log
+WriteToLog.LogMessage.Label=Messaggio di log
+WriteToLog.LogSubject.Label=Oggetto del log
+WriteToLog.Name.Default=Scrivi nel log
+WriteToLog.Title=Scrivi nel log
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ja_JP.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ja_JP.properties
index fc1c64aa91..6dfdb19170 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ja_JP.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ja_JP.properties
@@ -20,12 +20,11 @@
 
 ActionWriteToLog.Description=Write message to 
log\n\u30ed\u30b0\u66f8\u304d\u8fbc\u307f
 ActionWriteToLog.Name=\u30ed\u30b0\u66f8\u304d\u8fbc\u307f
-WriteToLog.ActionName.Label=\u30b8\u30e7\u30d6\u540d 
+WriteToLog.ActionName.Label=\u30b8\u30e7\u30d6\u540d
 WriteToLog.Error.Description=The following error occurred
 WriteToLog.Error.Label=ERROR
-WriteToLog.Error.UnableToLoadFromXML.Label=Unable to load action of type 
'Write to log' from XML node
 WriteToLog.Loglevel.Label=\u30ed\u30b0\u30fb\u30ec\u30d9\u30eb
 WriteToLog.LogMessage.Label=\u30e1\u30c3\u30bb\u30fc\u30b8
 WriteToLog.LogSubject.Label=\u4ef6\u540d
-WriteToLog.Name.Default=\u30ed\u30b0\u66f8\u304d\u8fbc\u307f 
-WriteToLog.Title=\u30ed\u30b0\u66f8\u304d\u8fbc\u307f 
+WriteToLog.Name.Default=\u30ed\u30b0\u66f8\u304d\u8fbc\u307f
+WriteToLog.Title=\u30ed\u30b0\u66f8\u304d\u8fbc\u307f
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ko_KR.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ko_KR.properties
index d025636512..8b393d7fe7 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ko_KR.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_ko_KR.properties
@@ -18,12 +18,11 @@
 #
 #
 
-WriteToLog.ActionName.Label=Workflow \uC5D4\uD2B8\uB9AC \uC774\uB984 
+WriteToLog.ActionName.Label=Workflow \uC5D4\uD2B8\uB9AC \uC774\uB984
 WriteToLog.Error.Description=\uB2E4\uC74C\uACFC \uAC19\uC740 \uC624\uB958 
\uBC1C\uC0DD
 WriteToLog.Error.Label=\uC624\uB958
-WriteToLog.Error.UnableToLoadFromXML.Label=Unable to load action of type 
'Write to log' from XML node
 WriteToLog.Loglevel.Label=\uB85C\uADF8 \uB808\uBCA8
 WriteToLog.LogMessage.Label=\uB85C\uADF8 \uBA54\uC138\uC9C0
 WriteToLog.LogSubject.Label=\uB85C\uADF8 \uC81C\uBAA9
-WriteToLog.Name.Default=Write to log 
-WriteToLog.Title=Write to log 
+WriteToLog.Name.Default=Write to log
+WriteToLog.Title=Write to log
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_nl_NL.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_nl_NL.properties
index d8c912c6b2..919003f4bd 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_nl_NL.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_nl_NL.properties
@@ -18,4 +18,3 @@
 #
 #
 
-WriteToLog.Error.UnableToLoadFromXML.Label=Het was niet mogelijk om de action 
van het type 'Write to log' te laden vanuit XML.
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_pt_BR.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_pt_BR.properties
index 2c56761d62..51e37ce3f9 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_pt_BR.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_pt_BR.properties
@@ -20,12 +20,11 @@
 ActionWriteToLog.Description=Escrever mensagem no registro
 ActionWriteToLog.keyword=escrever,registro
 ActionWriteToLog.Name=Escrever em registro
-WriteToLog.ActionName.Label=Nome da a\u00E7\u00E3o: 
+WriteToLog.ActionName.Label=Nome da a\u00E7\u00E3o
 WriteToLog.Error.Description=O erro seguinte ocorreu
 WriteToLog.Error.Label=Erro
-WriteToLog.Error.UnableToLoadFromXML.Label=imposs\u00EDvel ler a\u00E7\u00E3o 
do tipo "escrever em registro" a partir do n\u00F3 XML
-WriteToLog.Loglevel.Label=N\u00EDvel de registro 
-WriteToLog.LogMessage.Label=Registrar mensagem    
-WriteToLog.LogSubject.Label=Assunto do registro   
-WriteToLog.Name.Default=Escrever em registro 
-WriteToLog.Title=Escrever em registro 
+WriteToLog.Loglevel.Label=N\u00EDvel de registro
+WriteToLog.LogMessage.Label=Registrar mensagem
+WriteToLog.LogSubject.Label=Assunto do registro
+WriteToLog.Name.Default=Escrever em registro
+WriteToLog.Title=Escrever em registro
diff --git 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_zh_CN.properties
 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_zh_CN.properties
index 8b76165327..5d4da37362 100644
--- 
a/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_zh_CN.properties
+++ 
b/plugins/actions/writetolog/src/main/resources/org/apache/hop/workflow/actions/writetolog/messages/messages_zh_CN.properties
@@ -20,7 +20,7 @@
 ActionWriteToLog.Description=Write message to log
 ActionWriteToLog.keyword=write,log
 ActionWriteToLog.Name=\u5199\u65E5\u5FD7
-WriteToLog.ActionName.Label=Action \u540D\u79F0:
+WriteToLog.ActionName.Label=Action \u540D\u79F0
 WriteToLog.Error.Description=\u53D1\u751F\u4EE5\u4E0B\u9519\u8BEF
 WriteToLog.Error.Label=\u9519\u8BEF
 WriteToLog.Error.UnableToLoadFromXML.Label=\u65E0\u6CD5\u4ECE XML 
\u8282\u70B9\u52A0\u8F7D "\u5199\u65E5\u5FD7" \u7C7B\u578B\u7684 Action

Reply via email to