This is an automated email from the ASF dual-hosted git repository. nadment pushed a commit to branch 2041 in repository https://gitbox.apache.org/repos/asf/hop.git
commit 7eb638d6458e502615a229d7e0431f567d5b1176 Author: Nicolas Adment <[email protected]> AuthorDate: Thu Jul 25 22:44:17 2024 +0200 Deprecate ActionBase.getUsedDatabaseConnections method #2041 --- .../main/java/org/apache/hop/workflow/action/ActionBase.java | 1 + .../actions/checkdbconnection/ActionCheckDbConnections.java | 11 ----------- .../hop/workflow/actions/columnsexist/ActionColumnsExist.java | 7 ------- .../actions/evaluatetablecontent/ActionEvalTableContent.java | 7 ------- .../workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java | 7 ------- .../workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java | 7 ------- .../workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java | 7 ------- .../java/org/apache/hop/workflow/actions/sql/ActionSql.java | 5 ----- .../hop/workflow/actions/waitforsql/ActionWaitForSql.java | 5 ----- 9 files changed, 1 insertion(+), 56 deletions(-) diff --git a/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java b/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java index 1011a4b627..43261bc589 100644 --- a/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java +++ b/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java @@ -481,6 +481,7 @@ public abstract class ActionBase * * @return an empty (non-null) array */ + @Deprecated(since = "2.10") public DatabaseMeta[] getUsedDatabaseConnections() { return new DatabaseMeta[] {}; } diff --git a/plugins/actions/checkdbconnection/src/main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java b/plugins/actions/checkdbconnection/src/main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java index a733167968..315bddf368 100644 --- a/plugins/actions/checkdbconnection/src/main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java +++ b/plugins/actions/checkdbconnection/src/main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java @@ -195,17 +195,6 @@ public class ActionCheckDbConnections extends ActionBase implements Cloneable, I return true; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - List<DatabaseMeta> used = new ArrayList<>(); - for (CDConnection connection : connections) { - if (connection.getDatabaseMeta() != null) { - used.add(connection.getDatabaseMeta()); - } - } - return used.toArray(new DatabaseMeta[0]); - } - @Override public List<ResourceReference> getResourceDependencies( IVariables variables, WorkflowMeta workflowMeta) { diff --git a/plugins/actions/columnsexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java b/plugins/actions/columnsexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java index 92a17ba722..0eeb352c4c 100644 --- a/plugins/actions/columnsexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java +++ b/plugins/actions/columnsexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java @@ -226,13 +226,6 @@ public class ActionColumnsExist extends ActionBase implements Cloneable, IAction return result; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[] { - databaseMeta, - }; - } - @Override public List<ResourceReference> getResourceDependencies( IVariables variables, WorkflowMeta workflowMeta) { diff --git a/plugins/actions/evaluatetablecontent/src/main/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java b/plugins/actions/evaluatetablecontent/src/main/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java index cc2eb9e333..08b4801026 100644 --- a/plugins/actions/evaluatetablecontent/src/main/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java +++ b/plugins/actions/evaluatetablecontent/src/main/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java @@ -405,13 +405,6 @@ public class ActionEvalTableContent extends ActionBase implements Cloneable, IAc return result; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[] { - connection, - }; - } - @Override public List<ResourceReference> getResourceDependencies( IVariables variables, WorkflowMeta workflowMeta) { diff --git a/plugins/actions/mssqlbulkload/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java b/plugins/actions/mssqlbulkload/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java index 4f28ee4f9b..beda3610cc 100644 --- a/plugins/actions/mssqlbulkload/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java +++ b/plugins/actions/mssqlbulkload/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java @@ -559,13 +559,6 @@ public class ActionMssqlBulkLoad extends ActionBase implements Cloneable, IActio return result; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[] { - connection, - }; - } - public void setFilename(String filename) { this.filename = filename; } diff --git a/plugins/actions/mysqlbulkfile/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java b/plugins/actions/mysqlbulkfile/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java index 5cc5412bb2..92676a3e9c 100644 --- a/plugins/actions/mysqlbulkfile/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java +++ b/plugins/actions/mysqlbulkfile/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java @@ -424,13 +424,6 @@ public class ActionMysqlBulkFile extends ActionBase implements Cloneable, IActio return result; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[] { - connection, - }; - } - public void setHighPriority(boolean highpriority) { this.highPriority = highpriority; } diff --git a/plugins/actions/mysqlbulkload/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java b/plugins/actions/mysqlbulkload/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java index 73e4a9d917..0118046111 100644 --- a/plugins/actions/mysqlbulkload/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java +++ b/plugins/actions/mysqlbulkload/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java @@ -431,13 +431,6 @@ public class ActionMysqlBulkLoad extends ActionBase implements Cloneable, IActio return result; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[] { - connection, - }; - } - public boolean isReplacedata() { return replacedata; } diff --git a/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java b/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java index d4fc2b1006..2beb7c731d 100644 --- a/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java +++ b/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java @@ -254,11 +254,6 @@ public class ActionSql extends ActionBase implements Cloneable, IAction { return true; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[0]; - } - @Override public List<ResourceReference> getResourceDependencies( IVariables variables, WorkflowMeta workflowMeta) { diff --git a/plugins/actions/waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java b/plugins/actions/waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java index 017cdfccb1..b7db626865 100644 --- a/plugins/actions/waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java +++ b/plugins/actions/waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java @@ -471,11 +471,6 @@ public class ActionWaitForSql extends ActionBase implements Cloneable, IAction { return successOK; } - @Override - public DatabaseMeta[] getUsedDatabaseConnections() { - return new DatabaseMeta[0]; - } - @Override public List<ResourceReference> getResourceDependencies( IVariables variables, WorkflowMeta workflowMeta) {
