This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new f82bb9379d Git diff visual needs some adjustment #5996 (#5997)
f82bb9379d is described below
commit f82bb9379d43febe23777a5584ee508f60b38185
Author: Nicolas Adment <[email protected]>
AuthorDate: Fri Nov 14 16:25:56 2025 +0100
Git diff visual needs some adjustment #5996 (#5997)
---
.../org/apache/hop/git/DrawDiffOnActionExtensionPoint.java | 4 ++--
.../apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java | 13 ++++---------
.../apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java | 13 ++++---------
3 files changed, 10 insertions(+), 20 deletions(-)
diff --git
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java
index f5c9f3670c..2d7ba1d880 100644
---
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java
+++
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java
@@ -87,8 +87,8 @@ public class DrawDiffOnActionExtensionPoint implements
IExtensionPoint {
new SvgFile(location, getClass().getClassLoader()),
(int) x,
(int) y,
- iconSize / 4,
- iconSize / 4,
+ iconSize / 2,
+ iconSize / 2,
gc.getMagnification(),
0);
} catch (Exception e) {
diff --git
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java
index dccedf99a4..367bb35e08 100644
---
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java
+++
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java
@@ -83,7 +83,6 @@ public class DrawDiffOnPipelineHopExtensionPoint
//
Point fr = ext.pipelineHop.getFromTransform().getLocation();
Point to = ext.pipelineHop.getToTransform().getLocation();
- Point middle = new Point((fr.x + to.x) / 2, (fr.y + to.y) / 2);
int iconSize = ConstUi.ICON_SIZE;
try {
@@ -92,14 +91,10 @@ public class DrawDiffOnPipelineHopExtensionPoint
// Exception when accessed from Hop Server
}
- gc.drawImage(
- svgFile,
- middle.x,
- middle.y,
- iconSize / 2,
- iconSize / 2,
- gc.getMagnification(),
- 0);
+ int x = (int) (ext.offset.x) + (fr.x + to.x) / 2 + iconSize / 4;
+ int y = (int) (ext.offset.y) + (fr.y + to.y) / 2 + iconSize / 4;
+
+ gc.drawImage(svgFile, x, y, iconSize / 2, iconSize / 2,
gc.getMagnification(), 0);
}
}
}
diff --git
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java
index 533071e673..2442f7b057 100644
---
a/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java
+++
b/plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java
@@ -84,7 +84,6 @@ public class DrawDiffOnWorkflowHopExtensionPoint
//
Point fr = ext.workflowHop.getFromAction().getLocation();
Point to = ext.workflowHop.getToAction().getLocation();
- Point middle = new Point((fr.x + to.x) / 2, (fr.y + to.y) / 2);
int iconSize = ConstUi.ICON_SIZE;
try {
@@ -93,14 +92,10 @@ public class DrawDiffOnWorkflowHopExtensionPoint
// Exception when accessed from Hop Server
}
- gc.drawImage(
- svgFile,
- middle.x,
- middle.y,
- iconSize / 2,
- iconSize / 2,
- gc.getMagnification(),
- 0);
+ int x = (int) (ext.offset.x) + (fr.x + to.x) / 2 + iconSize / 4;
+ int y = (int) (ext.offset.y) + (fr.y + to.y) / 2 + iconSize / 4;
+
+ gc.drawImage(svgFile, x, y, iconSize / 2, iconSize / 2,
gc.getMagnification(), 0);
}
}
}
