(hop) branch main updated: In case of a loop, stop drawing hop candidate before displaying the message #6202 (#6203)

[mcasters]

This is an automated email from the ASF dual-hosted git repository.

mcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new b1f1067ffb In case of a loop, stop drawing hop candidate before 
displaying the message #6202 (#6203)
b1f1067ffb is described below

commit b1f1067ffb69c376974dbc59bd02896c8b7ff7bc
Author: Nicolas Adment <39568358+nadm...@users.noreply.github.com>
AuthorDate: Mon Dec 15 14:54:42 2025 +0100

    In case of a loop, stop drawing hop candidate before displaying the message 
#6202 (#6203)
---
 .../org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java    | 1 +
 .../org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java    | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
index 13054a95f5..3acdeafb58 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
@@ -1829,6 +1829,7 @@ public class HopGuiPipelineGraph extends 
HopGuiAbstractGraph
     if (candidate == null) {
       return;
     }
+    this.startHopTransform = null;
     switch (stream.getStreamType()) {
       case ERROR:
         addErrorHop();
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
index c1dddfcf7a..4221cfb1ac 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
@@ -1447,11 +1447,12 @@ public class HopGuiWorkflowGraph extends 
HopGuiAbstractGraph
         workflowMeta.addWorkflowHop(hopCandidate);
         WorkflowHopMeta theHopCandidate = hopCandidate;
         if (workflowMeta.hasLoop(hopCandidate.getToAction())) {
+          workflowMeta.removeWorkflowHop(theHopCandidate);
+          startHopAction = null;
           MessageBox mb = new MessageBox(hopGui.getActiveShell(), SWT.OK | 
SWT.ICON_WARNING);
           mb.setMessage(BaseMessages.getString(PKG, 
"WorkflowGraph.Dialog.HopCausesLoop.Message"));
           mb.setText(BaseMessages.getString(PKG, 
"WorkflowGraph.Dialog.HopCausesLoop.Title"));
           mb.open();
-          workflowMeta.removeWorkflowHop(theHopCandidate);
           cancel = true;
         }
         if (!cancel) {