This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 3cbe512283 Logging performance fix (#6240)
3cbe512283 is described below
commit 3cbe512283390c3e098a7cd5dad890315d4d1c1f
Author: Josh Downing <[email protected]>
AuthorDate: Mon Dec 22 02:44:36 2025 -0500
Logging performance fix (#6240)
* Filter before instantiating log messages
* apply spotless formatter
---
.../org/apache/hop/core/logging/LogChannel.java | 46 +++++++++++++++-------
1 file changed, 31 insertions(+), 15 deletions(-)
diff --git a/core/src/main/java/org/apache/hop/core/logging/LogChannel.java
b/core/src/main/java/org/apache/hop/core/logging/LogChannel.java
index 852e18a8dc..af7c13c394 100644
--- a/core/src/main/java/org/apache/hop/core/logging/LogChannel.java
+++ b/core/src/main/java/org/apache/hop/core/logging/LogChannel.java
@@ -152,71 +152,87 @@ public class LogChannel implements ILogChannel {
println(traceMessage, channelLogLevel);
}
+ public void logWithLevel(String s, LogLevel logMessageLevel) {
+ if (logMessageLevel.isVisible(logLevel)) {
+ println(new LogMessage(s, logChannelId, logMessageLevel, simplified),
logLevel);
+ }
+ }
+
+ public void logWithLevel(String s, Throwable e, LogLevel logMessageLevel) {
+ if (logMessageLevel.isVisible(logLevel)) {
+ println(new LogMessage(s, logChannelId, logMessageLevel, simplified), e,
logLevel);
+ }
+ }
+
+ public void logWithLevel(String s, LogLevel logMessageLevel, Object...
arguments) {
+ if (logMessageLevel.isVisible(logLevel)) {
+ println(new LogMessage(s, logChannelId, arguments, logMessageLevel,
simplified), logLevel);
+ }
+ }
+
@Override
public void logMinimal(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.MINIMAL, simplified),
logLevel);
+ logWithLevel(s, LogLevel.MINIMAL);
}
@Override
public void logBasic(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.BASIC, simplified),
logLevel);
+ logWithLevel(s, LogLevel.BASIC);
}
@Override
public void logError(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.ERROR, simplified),
logLevel);
+ logWithLevel(s, LogLevel.ERROR);
}
@Override
public void logError(String s, Throwable e) {
- println(new LogMessage(s, logChannelId, LogLevel.ERROR, simplified), e,
logLevel);
+ logWithLevel(s, e, LogLevel.ERROR);
}
@Override
public void logBasic(String s, Object... arguments) {
- println(new LogMessage(s, logChannelId, arguments, LogLevel.BASIC,
simplified), logLevel);
+ logWithLevel(s, LogLevel.BASIC, arguments);
}
@Override
public void logDetailed(String s, Object... arguments) {
- println(new LogMessage(s, logChannelId, arguments, LogLevel.DETAILED,
simplified), logLevel);
+ logWithLevel(s, LogLevel.DETAILED, arguments);
}
@Override
public void logError(String s, Object... arguments) {
- println(new LogMessage(s, logChannelId, arguments, LogLevel.ERROR,
simplified), logLevel);
+ logWithLevel(s, LogLevel.ERROR, arguments);
}
@Override
public void logDetailed(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.DETAILED, simplified),
logLevel);
+ logWithLevel(s, LogLevel.DETAILED);
}
@Override
public void logDebug(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.DEBUG, simplified),
logLevel);
+ logWithLevel(s, LogLevel.DEBUG);
}
@Override
public void logDebug(String message, Object... arguments) {
- println(new LogMessage(message, logChannelId, arguments, LogLevel.DEBUG,
simplified), logLevel);
+ logWithLevel(message, LogLevel.DEBUG, arguments);
}
@Override
public void logRowlevel(String s) {
- println(new LogMessage(s, logChannelId, LogLevel.ROWLEVEL, simplified),
logLevel);
+ logWithLevel(s, LogLevel.ROWLEVEL);
}
@Override
public void logMinimal(String message, Object... arguments) {
- println(
- new LogMessage(message, logChannelId, arguments, LogLevel.MINIMAL,
simplified), logLevel);
+ logWithLevel(message, LogLevel.MINIMAL, arguments);
}
@Override
public void logRowlevel(String message, Object... arguments) {
- println(
- new LogMessage(message, logChannelId, arguments, LogLevel.ROWLEVEL,
simplified), logLevel);
+ logWithLevel(message, LogLevel.ROWLEVEL, arguments);
}
@Override