This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 106307ed83 Detaching a unit test shouldnt edit the test or thrown an
Error (#6361)
106307ed83 is described below
commit 106307ed83651ad51e440887cd1bf0e7bb35242a
Author: lance <[email protected]>
AuthorDate: Tue Jan 13 21:04:54 2026 +0800
Detaching a unit test shouldnt edit the test or thrown an Error (#6361)
Signed-off-by: lance <[email protected]>
---
.../src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
a/plugins/misc/testing/src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java
b/plugins/misc/testing/src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java
index 958714e8e9..709f22dfaf 100644
---
a/plugins/misc/testing/src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java
+++
b/plugins/misc/testing/src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java
@@ -42,6 +42,7 @@ import org.apache.hop.core.row.RowDataUtil;
import org.apache.hop.core.row.RowMeta;
import org.apache.hop.core.row.value.ValueMetaString;
import org.apache.hop.core.util.StringUtil;
+import org.apache.hop.core.util.Utils;
import org.apache.hop.core.variables.IVariables;
import org.apache.hop.core.variables.Variables;
import org.apache.hop.i18n.BaseMessages;
@@ -1139,7 +1140,6 @@ public class TestingGuiPlugin {
extraWidth = 200,
toolTip =
"i18n::TestingGuiPlugin.ToolbarElement.GetUnitTestList.Tooltip")
public void selectUnitTest() {
-
HopGui hopGui = HopGui.getInstance();
try {
PipelineMeta pipelineMeta = getActivePipelineMeta();
@@ -1157,7 +1157,7 @@ public class TestingGuiPlugin {
metadataProvider.getSerializer(PipelineUnitTest.class);
String testName = combo.getText();
- if (testName != null) {
+ if (!Utils.isEmpty(testName)) {
PipelineUnitTest unitTest = testSerializer.load(testName);
if (unitTest == null) {
throw new HopException(
@@ -1168,7 +1168,6 @@ public class TestingGuiPlugin {
selectUnitTest(pipelineMeta, unitTest);
// Update the pipeline graph
- //
hopGui.getActiveFileTypeHandler().updateGui();
}
} catch (Exception e) {