This is an automated email from the ASF dual-hosted git repository.
mattcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 6f2d5a1ce5 Deprecate unused plugin ID and name setters from
IVariableResolver #7392 (#7399)
6f2d5a1ce5 is described below
commit 6f2d5a1ce57a66db7d45797d720083e20962c2b9
Author: Nicolas Adment <[email protected]>
AuthorDate: Thu Jul 2 18:56:02 2026 +0200
Deprecate unused plugin ID and name setters from IVariableResolver #7392
(#7399)
* Deprecate unused plugin ID and name setters from IVariableResolver #7392
* spotless
---------
Co-authored-by: Hans Van Akelyen <[email protected]>
---
.../apache/hop/core/variables/resolver/IVariableResolver.java | 6 ++++--
.../hop/resolvers/pipeline/VariableResolverPipeline.java | 6 ------
.../core/variables/resolver/AzureKeyVaultVariableResolver.java | 10 ----------
.../variables/resolver/GooleSecretManagerVariableResolver.java | 10 ----------
.../variables/resolver/vault/BaseVaultVariableResolver.java | 10 ----------
5 files changed, 4 insertions(+), 38 deletions(-)
diff --git
a/core/src/main/java/org/apache/hop/core/variables/resolver/IVariableResolver.java
b/core/src/main/java/org/apache/hop/core/variables/resolver/IVariableResolver.java
index 20a2a514c6..f2133ba206 100644
---
a/core/src/main/java/org/apache/hop/core/variables/resolver/IVariableResolver.java
+++
b/core/src/main/java/org/apache/hop/core/variables/resolver/IVariableResolver.java
@@ -37,11 +37,13 @@ public interface IVariableResolver {
*/
String resolve(String secretPath, IVariables variables) throws HopException;
- void setPluginId();
+ @Deprecated(since = "2.19")
+ default void setPluginId() {}
String getPluginId();
- void setPluginName(String pluginName);
+ @Deprecated(since = "2.19")
+ default void setPluginName(String pluginName) {}
String getPluginName();
}
diff --git
a/plugins/resolvers/pipeline/src/main/java/org/apache/hop/resolvers/pipeline/VariableResolverPipeline.java
b/plugins/resolvers/pipeline/src/main/java/org/apache/hop/resolvers/pipeline/VariableResolverPipeline.java
index cd89a31509..91898554c8 100644
---
a/plugins/resolvers/pipeline/src/main/java/org/apache/hop/resolvers/pipeline/VariableResolverPipeline.java
+++
b/plugins/resolvers/pipeline/src/main/java/org/apache/hop/resolvers/pipeline/VariableResolverPipeline.java
@@ -106,17 +106,11 @@ public class VariableResolverPipeline implements
IVariableResolver {
// This space was intentionally left blank.
}
- @Override
- public void setPluginId() {}
-
@Override
public String getPluginId() {
return "Variable-Resolver-Pipeline";
}
- @Override
- public void setPluginName(String pluginName) {}
-
@Override
public String getPluginName() {
return "Pipeline Variable Resolver";
diff --git
a/plugins/tech/azure/src/main/java/org/apache/hop/core/variables/resolver/AzureKeyVaultVariableResolver.java
b/plugins/tech/azure/src/main/java/org/apache/hop/core/variables/resolver/AzureKeyVaultVariableResolver.java
index 6afea27ae6..500056bb04 100644
---
a/plugins/tech/azure/src/main/java/org/apache/hop/core/variables/resolver/AzureKeyVaultVariableResolver.java
+++
b/plugins/tech/azure/src/main/java/org/apache/hop/core/variables/resolver/AzureKeyVaultVariableResolver.java
@@ -207,21 +207,11 @@ public class AzureKeyVaultVariableResolver implements
IVariableResolver {
}
}
- @Override
- public void setPluginId() {
- /* Not needed */
- }
-
@Override
public String getPluginId() {
return "AzureKeyVault";
}
- @Override
- public void setPluginName(String pluginName) {
- /* Not needed */
- }
-
@Override
public String getPluginName() {
return "Azure Key Vault Variable Resolver";
diff --git
a/plugins/tech/google/src/main/java/org/apache/hop/core/variables/resolver/GooleSecretManagerVariableResolver.java
b/plugins/tech/google/src/main/java/org/apache/hop/core/variables/resolver/GooleSecretManagerVariableResolver.java
index f38ad6e7db..8f57b674c1 100644
---
a/plugins/tech/google/src/main/java/org/apache/hop/core/variables/resolver/GooleSecretManagerVariableResolver.java
+++
b/plugins/tech/google/src/main/java/org/apache/hop/core/variables/resolver/GooleSecretManagerVariableResolver.java
@@ -121,21 +121,11 @@ public class GooleSecretManagerVariableResolver
implements IVariableResolver {
}
}
- @Override
- public void setPluginId() {
- // Nothing to set
- }
-
@Override
public String getPluginId() {
return "Variable-Resolver-GoogleSecretManager";
}
- @Override
- public void setPluginName(String pluginName) {
- // Nothing to set
- }
-
@Override
public String getPluginName() {
return "Google Secret Manager Variable Resolver";
diff --git
a/plugins/tech/vault/src/main/java/org/apache/hop/core/variables/resolver/vault/BaseVaultVariableResolver.java
b/plugins/tech/vault/src/main/java/org/apache/hop/core/variables/resolver/vault/BaseVaultVariableResolver.java
index 221a214f4c..02d28c1794 100644
---
a/plugins/tech/vault/src/main/java/org/apache/hop/core/variables/resolver/vault/BaseVaultVariableResolver.java
+++
b/plugins/tech/vault/src/main/java/org/apache/hop/core/variables/resolver/vault/BaseVaultVariableResolver.java
@@ -232,11 +232,6 @@ public abstract class BaseVaultVariableResolver implements
IVariableResolver {
return utf8.toString();
}
- @Override
- public void setPluginId() {
- // Nothing to set
- }
-
@Override
public void init() {
// Not used today
@@ -245,11 +240,6 @@ public abstract class BaseVaultVariableResolver implements
IVariableResolver {
@Override
public abstract String getPluginId();
- @Override
- public void setPluginName(String pluginName) {
- // Nothing to set
- }
-
@Override
public abstract String getPluginName();
}
