(hop) branch main updated: Avoid updating disposed menu items (#7738)

[mcasters]

This is an automated email from the ASF dual-hosted git repository.

mattcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 30d226bca3 Avoid updating disposed menu items (#7738)
30d226bca3 is described below

commit 30d226bca32b94e9e59d90230f4b6a7132fee1f5
Author: Gabriel Dutra <gvdu...@apache.org>
AuthorDate: Sat Aug 1 13:01:39 2026 -0700

    Avoid updating disposed menu items (#7738)
    
    Co-authored-by: gabrieldutra <gdut...@gatech.edu>
---
 .../org/apache/hop/ui/core/gui/GuiMenuWidgets.java |  2 +-
 .../ui/core/gui/GuiMenuWidgetsDisposedTest.java    | 48 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 1 deletion(-)

diff --git a/ui/src/main/java/org/apache/hop/ui/core/gui/GuiMenuWidgets.java 
b/ui/src/main/java/org/apache/hop/ui/core/gui/GuiMenuWidgets.java
index 0496ecb050..6433f1f109 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/gui/GuiMenuWidgets.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/gui/GuiMenuWidgets.java
@@ -365,7 +365,7 @@ public class GuiMenuWidgets extends BaseGuiWidgets {
     boolean hasCapability =
         handler != null ? handler.hasCapability(permission) : 
fileType.hasCapability(permission);
     boolean enable = hasCapability && active;
-    if (menuItem != null && enable != menuItem.isEnabled()) {
+    if (menuItem != null && !menuItem.isDisposed() && enable != 
menuItem.isEnabled()) {
       menuItem.setEnabled(enable);
     }
     menuEnabledMap.put(id, enable);
diff --git 
a/ui/src/test/java/org/apache/hop/ui/core/gui/GuiMenuWidgetsDisposedTest.java 
b/ui/src/test/java/org/apache/hop/ui/core/gui/GuiMenuWidgetsDisposedTest.java
new file mode 100644
index 0000000000..13bec5b868
--- /dev/null
+++ 
b/ui/src/test/java/org/apache/hop/ui/core/gui/GuiMenuWidgetsDisposedTest.java
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hop.ui.core.gui;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Map;
+import org.apache.hop.ui.hopgui.file.IHopFileType;
+import org.eclipse.swt.widgets.MenuItem;
+import org.junit.jupiter.api.Test;
+
+class GuiMenuWidgetsDisposedTest {
+
+  @Test
+  void ignoresDisposedMenuItemWhenUpdatingCapability() {
+    String id = "file-save";
+    String permission = "save";
+    IHopFileType fileType = mock(IHopFileType.class);
+    MenuItem menuItem = mock(MenuItem.class);
+    when(fileType.hasCapability(permission)).thenReturn(true);
+    when(menuItem.isDisposed()).thenReturn(true);
+
+    GuiMenuWidgets widgets = new GuiMenuWidgets();
+    widgets.setMenuItemMap(Map.of(id, menuItem));
+
+    widgets.enableMenuItem(fileType, id, permission);
+
+    verify(menuItem, never()).isEnabled();
+    verify(menuItem, never()).setEnabled(true);
+  }
+}