(hop) branch main updated: issue #7786: subtler check results colors and show OK when no errors (#7787)

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 6a58471d86 issue #7786: subtler check results colors and show OK when 
no errors (#7787)
6a58471d86 is described below

commit 6a58471d86649d44c3b1a9ff0998384b7af303bb
Author: Matt Casters <mattcast...@gmail.com>
AuthorDate: Wed Aug 5 13:41:42 2026 +0200

    issue #7786: subtler check results colors and show OK when no errors (#7787)
    
    Use pastel GuiResource backgrounds instead of full system red/yellow,
    and show successful results by default when the check has no errors.
---
 .../org/apache/hop/ui/core/dialog/CheckResultDialog.java    | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/ui/src/main/java/org/apache/hop/ui/core/dialog/CheckResultDialog.java 
b/ui/src/main/java/org/apache/hop/ui/core/dialog/CheckResultDialog.java
index 728b5a3f32..eb2ee397df 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/dialog/CheckResultDialog.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/dialog/CheckResultDialog.java
@@ -64,9 +64,6 @@ public class CheckResultDialog extends Dialog {
   private Shell shell;
   private final PropsUi props;
 
-  private Color red;
-  private Color yellow;
-
   private boolean showSuccessfulResults = false;
 
   private String transformName;
@@ -82,8 +79,9 @@ public class CheckResultDialog extends Dialog {
     Shell parent = getParent();
     Display display = parent.getDisplay();
 
-    red = display.getSystemColor(SWT.COLOR_RED);
-    yellow = display.getSystemColor(SWT.COLOR_YELLOW);
+    // Show successful results by default when there are no errors
+    showSuccessfulResults =
+        remarks.stream().noneMatch(cr -> cr.getType() == 
ICheckResult.TYPE_RESULT_ERROR);
 
     shell = new Shell(parent, SWT.DIALOG_TRIM | SWT.RESIZE | SWT.MAX);
     PropsUi.setLook(shell);
@@ -115,6 +113,7 @@ public class CheckResultDialog extends Dialog {
 
     wNoOK = new Button(shell, SWT.CHECK);
     wNoOK.setText(STRING_SHOW_SUCESSFUL);
+    wNoOK.setSelection(showSuccessfulResults);
     PropsUi.setLook(wNoOK);
     FormData fd = new FormData();
     fd.left = new FormAttachment(0, 0);
@@ -220,10 +219,10 @@ public class CheckResultDialog extends Dialog {
         Color col = null;
         switch (cr.getType()) {
           case ICheckResult.TYPE_RESULT_ERROR:
-            col = red;
+            col = GuiResource.getInstance().getColorLightRed();
             break;
           case ICheckResult.TYPE_RESULT_WARNING:
-            col = yellow;
+            col = GuiResource.getInstance().getColorLight();
             break;
           default:
             break;