This is an automated email from the ASF dual-hosted git repository.

mattcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 076dbfc48a Fix Multi Mapping metadata injection test keys (#7972)
076dbfc48a is described below

commit 076dbfc48a46c73e62f27bbb8765dd4a52a34a89
Author: Matt Casters <[email protected]>
AuthorDate: Sat Aug 15 14:35:14 2026 +0200

    Fix Multi Mapping metadata injection test keys (#7972)
    
    MultiMappingMetaInjectionTest used the XML key inherit_all_vars and skipped
    the XML names for variable mappings. BeanInjectionInfo only registers
    INHERIT_ALL_VARIABLES, VARIABLE and VALUE, so hop-transform-mapping failed
    on CI.
---
 .../multimapping/MultiMappingMetaInjectionTest.java          | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git 
a/plugins/transforms/mapping/src/test/java/org/apache/hop/pipeline/transforms/multimapping/MultiMappingMetaInjectionTest.java
 
b/plugins/transforms/mapping/src/test/java/org/apache/hop/pipeline/transforms/multimapping/MultiMappingMetaInjectionTest.java
index eca9c35fa4..c8a381be3c 100644
--- 
a/plugins/transforms/mapping/src/test/java/org/apache/hop/pipeline/transforms/multimapping/MultiMappingMetaInjectionTest.java
+++ 
b/plugins/transforms/mapping/src/test/java/org/apache/hop/pipeline/transforms/multimapping/MultiMappingMetaInjectionTest.java
@@ -18,6 +18,7 @@ package org.apache.hop.pipeline.transforms.multimapping;
 
 import org.apache.hop.core.injection.BaseMetadataInjectionTestJunit5;
 import org.apache.hop.junit.rules.RestoreHopEngineEnvironmentExtension;
+import org.apache.hop.pipeline.transforms.mapping.MappingVariableMapping;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
@@ -34,6 +35,7 @@ class MultiMappingMetaInjectionTest extends 
BaseMetadataInjectionTestJunit5<Mult
     meta.getInputMappings().get(0).getValueRenames().add(new 
MultiMappingInputRename());
     meta.getOutputMappings().add(new MultiMappingOutputDefinition());
     meta.getOutputMappings().get(0).getValueRenames().add(new 
MultiMappingOutputRename());
+    meta.getMappingParameters().getVariableMappings().add(new 
MappingVariableMapping());
     setup(meta);
   }
 
@@ -53,16 +55,12 @@ class MultiMappingMetaInjectionTest extends 
BaseMetadataInjectionTestJunit5<Mult
     check("OUTPUT_DESCRIPTION", () -> 
meta.getOutputMappings().get(0).getDescription());
     check("OUTPUT_MAIN_PATH", () -> 
meta.getOutputMappings().get(0).isMainDataPath());
     check("OUTPUT_RENAME_ON_OUTPUT", () -> 
meta.getOutputMappings().get(0).isRenamingOnOutput());
-    check("inherit_all_vars", () -> 
meta.getMappingParameters().isInheritingAllVariables());
-    skipPropertyTest("variable");
-    skipPropertyTest("input");
+    check("INHERIT_ALL_VARIABLES", () -> 
meta.getMappingParameters().isInheritingAllVariables());
+    check("VARIABLE", () -> 
meta.getMappingParameters().getVariableMappings().get(0).getName());
+    check("VALUE", () -> 
meta.getMappingParameters().getVariableMappings().get(0).getValue());
     skipPropertyTest("INPUT_RENAME_SOURCE");
     skipPropertyTest("INPUT_RENAME_TARGET");
     skipPropertyTest("OUTPUT_RENAME_SOURCE");
     skipPropertyTest("OUTPUT_RENAME_TARGET");
-    skipPropertyTest("mappings");
-    skipPropertyTest("parameters");
-    skipPropertyTest("mapping");
-    skipPropertyTest("connector");
   }
 }

Reply via email to