ShiKaiWi commented on code in PR #1372:
URL:
https://github.com/apache/incubator-horaedb/pull/1372#discussion_r1432286764
##########
analytic_engine/src/instance/flush_compaction.rs:
##########
@@ -1062,6 +1079,40 @@ impl SpaceStore {
}
}
+/// Collect the column stats from a batch of sst meta data.
+fn collect_column_stats_from_meta_datas(metas: &[SstMetaData]) ->
HashMap<String, ColumnStats> {
+ let mut low_cardinality_counts: HashMap<String, usize> = HashMap::new();
Review Comment:
There is no entry for the columns whose cardinality is high, so I guess in
the most of cases there is no need to do memory allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
