ShiKaiWi commented on code in PR #1401:
URL:
https://github.com/apache/incubator-horaedb/pull/1401#discussion_r1435932130
##########
analytic_engine/src/instance/write.rs:
##########
@@ -422,15 +422,23 @@ impl<'a> Writer<'a> {
self.preprocess_write(&mut encode_ctx).await?;
- let encoded_payload = {
- let _timer =
self.table_data.metrics.start_table_write_encode_timer();
- let schema = self.table_data.schema();
- encode_ctx.encode(&self.instance.wal_encode, &schema)?
- };
+ let seq = if self.instance.disable_wal {
+ MIN_SEQUENCE_NUMBER
Review Comment:
The real sequence number should be returned, otherwise the merge procedure
may not work with the mock one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
