ShiKaiWi commented on code in PR #115: URL: https://github.com/apache/incubator-horaedb-docs/pull/115#discussion_r1435970960
########## docs/src/en/operation/system_table.md: ########## @@ -32,8 +31,8 @@ curl --location --request POST 'http://localhost:5000/sql' \ "rows":[ { "timestamp":0, - "catalog":"ceresdb", - "schema":"monitor_trace", + "catalog":"horaedb", Review Comment: Is the default catalog name changed? ########## docs/src/en/operation/system_table.md: ########## @@ -32,8 +31,8 @@ curl --location --request POST 'http://localhost:5000/sql' \ "rows":[ { "timestamp":0, - "catalog":"ceresdb", - "schema":"monitor_trace", + "catalog":"horaedb", + "schema":"public", Review Comment: Why is the old schema `monitor_trace`? If it is called `monitor_trace`, should it be changed? ########## docs/src/en/dev/profiling.md: ########## @@ -30,12 +30,12 @@ Example: // enable malloc prof export MALLOC_CONF=prof:true -// run ceresdb-server -./ceresdb-server .... +// run horaedb-server +./horaedb-server .... // 60s cpu sampling data curl -L '0:5000/debug/profile/heap/60' > /tmp/heap_profile -jeprof --show_bytes --pdf /usr/bin/ceresdb-server /tmp/heap_profile > profile_heap.pdf +jeprof --show_bytes --pdf /usr/bin/horaedb-server /tmp/heap_profile > profile_heap.pdf Review Comment: Is the binary name changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
