jiacai2050 commented on code in PR #1446:
URL:
https://github.com/apache/incubator-horaedb/pull/1446#discussion_r1458394060
##########
src/query_frontend/src/plan.rs:
##########
@@ -125,15 +138,15 @@ impl QueryPlan {
/// Note: When it timestamp filter evals to false(such as ts < 10 and ts >
/// 100), it will return None, which means no valid time range for this
/// query.
- fn extract_time_range(&self) -> Option<TimeRange> {
- let ts_column = if let Some(v) = self.find_timestamp_column() {
+ fn extract_time_range(&self) -> Result<Option<TimeRange>> {
+ let ts_column = if let Some(v) = self.find_timestamp_column()? {
v
} else {
warn!(
"Couldn't find time column, plan:{:?}, table_name:{:?}",
self.df_plan, self.table_name
);
- return Some(TimeRange::min_to_max());
+ return Ok(Some(TimeRange::min_to_max()));
Review Comment:
The error is already return in `self.find_timestamp_column()?`, the else
branch is when query range is not found, such as `select 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
