ZuLiangWang commented on code in PR #1450: URL: https://github.com/apache/incubator-horaedb/pull/1450#discussion_r1461426577
########## ctl/cmd/diagnose.go: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package cmd + +import ( + "github.com/apache/incubator-horaedb/ctl/operation" + "github.com/spf13/cobra" +) + +// diagnoseCmd represents the diagnose command Review Comment: Isn't it a bit redundant to create a file for every command? How about put interfaces of the same type together, for example `/api/v1/clusters`. ########## ctl/README.md: ########## @@ -0,0 +1,14 @@ +# HoraeCTL + + + +HoraeCTL is the operation tool for managing the HoraeDB cluster. + +## Quick Start +TODO + +## Contributing +The project is under rapid development so that any contribution is welcome. + +## License +HoraeMeta is under [Apache License 2.0](./LICENSE). Review Comment: ```suggestion HoraeCTL is under [Apache License 2.0](./LICENSE). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
