jiacai2050 commented on code in PR #1451:
URL:
https://github.com/apache/incubator-horaedb/pull/1451#discussion_r1465751466
##########
src/analytic_engine/src/engine.rs:
##########
@@ -234,6 +242,63 @@ impl TableEngine for TableEngineImpl {
self.close_tables_of_shard(close_requests).await
}
+
+ async fn report_statistics(&self) -> Result<Option<TableEngineStats>> {
Review Comment:
I think of one issue when using prometheus metrics to collect stats here,
when a shard is transferred to another node, this metrics will remain, so you
may collect those table twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
