jiacai2050 commented on code in PR #1488:
URL:
https://github.com/apache/incubator-horaedb/pull/1488#discussion_r1503954138
##########
src/common_types/src/datum.rs:
##########
@@ -765,6 +776,11 @@ impl Datum {
}
}
+ fn valid_is_utf8(s: &str) -> Result<()> {
Review Comment:
This check may be expensive for long string, better to add an option to
decide whether to do this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
