ShiKaiWi commented on code in PR #1503: URL: https://github.com/apache/incubator-horaedb/pull/1503#discussion_r1527987339
########## horaemeta/Dockerfile: ########## @@ -44,7 +44,9 @@ RUN chmod +x /usr/bin/horaemeta-server COPY ./docker/entrypoint.sh /entrypoint.sh COPY ./config/example-standalone.toml /etc/horaemeta/horaemeta.toml -COPY ./docker/tini /tini +ENV TINI_VERSION v0.19.0 Review Comment: Maybe we should move this line after L19. BTW, I guess `ARG` command should work better than `ENV` because `TINI_VERSION` is not necessary to be known by the started container. ########## horaemeta/Dockerfile: ########## @@ -44,7 +44,9 @@ RUN chmod +x /usr/bin/horaemeta-server COPY ./docker/entrypoint.sh /entrypoint.sh COPY ./config/example-standalone.toml /etc/horaemeta/horaemeta.toml -COPY ./docker/tini /tini +ENV TINI_VERSION v0.19.0 +ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini +RUN chmod +x /tini Review Comment: Remove this duplicate line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
