jiacai2050 commented on code in PR #1557:
URL: https://github.com/apache/horaedb/pull/1557#discussion_r1730597085
##########
src/components/object_store/src/disk_cache.rs:
##########
@@ -1334,9 +1333,14 @@ mod test {
let page_size = 8;
let first_create_time = {
let _store = {
- let local_path = tempdir().unwrap();
- let local_store =
-
Arc::new(LocalFileSystem::new_with_prefix(local_path.path()).unwrap());
+ let local_path =
tempdir().unwrap().as_ref().to_string_lossy().to_string();
Review Comment:
This setup is used in many places, how about add a method
`setup_local_store` to do it?
##########
src/components/object_store/src/config.rs:
##########
@@ -117,16 +127,21 @@ impl Default for HttpOptions {
}
#[derive(Debug, Clone, Deserialize, Serialize)]
-pub struct RetryOptions {
- pub max_retries: usize,
- pub retry_timeout: ReadableDuration,
+pub struct TimeoutOptions {
+ pub timeout: ReadableDuration,
Review Comment:
Add comments what their meaning are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
