Rachelint commented on code in PR #1563:
URL: https://github.com/apache/horaedb/pull/1563#discussion_r1758238186
##########
src/analytic_engine/src/compaction/runner/remote_runner.rs:
##########
@@ -16,27 +16,55 @@
// under the License.
use async_trait::async_trait;
-use cluster::ClusterRef;
+use compaction_client::{
+ compaction_impl::{build_compaction_client, CompactionClientConfig},
+ CompactionClientRef,
+};
use generic_error::BoxError;
use snafu::ResultExt;
+use super::node_picker::RemoteCompactionNodePickerRef;
use crate::{
compaction::runner::{CompactionRunner, CompactionRunnerResult,
CompactionRunnerTask},
- instance::flush_compaction::{ConvertCompactionTaskResponse, RemoteCompact,
Result},
+ instance::flush_compaction::{
+ BuildCompactionClientFailed, ConvertCompactionTaskResponse,
GetCompactionClientFailed,
+ PickCompactionNodeFailed, RemoteCompactFailed, Result,
+ },
};
pub struct RemoteCompactionRunner {
- pub cluster: ClusterRef,
+ pub node_picker: RemoteCompactionNodePickerRef,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
