LeslieKid commented on code in PR #1573:
URL: https://github.com/apache/horaedb/pull/1573#discussion_r1820667062
##########
integration_tests/Makefile:
##########
@@ -80,15 +85,20 @@ run-horaedb-cluster: build-horaedb
nohup ${HORAEDB_BINARY_PATH} --config ${HORAEDB_CONFIG_FILE_1} >
${CLUSTER_HORAEDB_STDOUT_FILE_1} 2>&1 &
sleep 30
-run: prepare build-meta
- $(HORAEDB_TEST_BINARY)
+run:
+ make run-local
+ make run-cluster
+ make run-compaction-offload
Review Comment:
In the previous implementation, it just run `prepare` to clear the old
process in the very beginning, which may lead to `ConnectError` bug. (e.g.
`run-local` and `run-cluster` use the same grpc port but the previous process
is not stop yet, which makes the later process can not use the port.)
The current implementation avoids the bug describe above by running
`prepare` before each (different) processes.
It needs further improvement in the future -- The log now looks a bit strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
