jiacai2050 commented on code in PR #1584:
URL: https://github.com/apache/horaedb/pull/1584#discussion_r1825467867
##########
src/wal/src/local_storage_impl/segment.rs:
##########
@@ -615,6 +615,32 @@ impl SegmentManager {
}
}
+pub struct SegmentTableMeta {
Review Comment:
> To minimize exposing the internal objects, I chose not to return all the
segments directly.
Sounds reasonable for me. I suggest we rename this struct to `SegmentView`
to represent it's a static version of segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
