baojinri commented on code in PR #1601:
URL: https://github.com/apache/horaedb/pull/1601#discussion_r1863146710


##########
horaedb/metric_engine/src/storage.rs:
##########
@@ -176,6 +190,15 @@ impl CloudObjectStorage {
         ));
         let df_schema = 
DFSchema::try_from(arrow_schema.clone()).context("build DFSchema")?;
         let write_props = Self::build_write_props(storage_opts.write_opts, 
num_primary_keys);
+        let sst_path_gen = Arc::new(SstPathGenerator::new(path.clone()));
+        let compact_scheduler = CompactionScheduler::new(
+            runtimes.sst_compact_runtime.clone(),
+            manifest.clone(),
+            store.clone(),
+            segment_duration,
+            sst_path_gen.clone(),
+            SchedulerConfig::default(),

Review Comment:
   add SchedulerConfig to storage_opts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to