jiacai2050 commented on code in PR #1617:
URL: https://github.com/apache/horaedb/pull/1617#discussion_r1895476922
##########
src/metric_engine/src/read.rs:
##########
@@ -430,17 +431,28 @@ impl ParquetReader {
let mut builder =
ParquetExec::builder(scan_config).with_parquet_file_reader_factory(
Arc::new(DefaultParquetFileReaderFactory::new(self.store.clone())),
);
- if let Some(expr) = conjunction(predicates) {
- let filters = create_physical_expr(&expr, &df_schema,
&ExecutionProps::new())
- .context("create physical expr")?;
- builder = builder.with_predicate(filters);
- }
+ let plan: Arc<dyn ExecutionPlan> = match conjunction(predicates) {
Review Comment:
base_plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
