n3nash commented on a change in pull request #620: Fix HUDI-27 : Support 
num_cores > 1 for writing through spark
URL: https://github.com/apache/incubator-hudi/pull/620#discussion_r270261240
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/io/storage/HoodieWrapperFileSystem.java
 ##########
 @@ -536,8 +536,9 @@ public void completeLocalOutput(Path fsOutputFile, Path 
tmpLocalFile) throws IOE
   }
 
   @Override
-  public void close() throws IOException {
-    fileSystem.close();
+  public void close() {
 
 Review comment:
   Well, ideally, you might not notice any difference now but ideally we want 
to call the fs.close() in your finally block if you are using the raw file 
system, so we should have some code clean up the fs connection and not depend 
on jvm shutdown.
   
   @vinothchandar 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to