n3nash commented on a change in pull request #599: Fixing small file handling, inline compaction defaults URL: https://github.com/apache/incubator-hudi/pull/599#discussion_r271003837
########## File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java ########## @@ -48,7 +48,7 @@ // Upsert uses this file size to compact new data onto existing files.. public static final String PARQUET_SMALL_FILE_LIMIT_BYTES = "hoodie.parquet.small.file.limit"; // Turned off by default - public static final String DEFAULT_PARQUET_SMALL_FILE_LIMIT_BYTES = String.valueOf(0); + public static final String DEFAULT_PARQUET_SMALL_FILE_LIMIT_BYTES = String.valueOf(104857600); Review comment: Can we put the equivalent MB size in the comments please ? It's easy to follow when objectively looking at the configs ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
