n3nash commented on a change in pull request #600:  Timeline Service with 
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271910582
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieReadClient.java
 ##########
 @@ -130,7 +124,7 @@ private void assertSqlContext() {
    * @return a dataframe
    */
   public Dataset<Row> read(JavaRDD<HoodieKey> hoodieKeys, int parallelism) 
throws Exception {
-
+    startEmbeddedServerView(hoodieKeys.map(k -> 
k.getPartitionPath()).distinct().collect());
 
 Review comment:
   May be a similar method like in HoodieWriteClient (getTableAndInitCtx) and 
move the table instantiation and embedded server instantiation there and call 
that in all these methods

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to