n3nash commented on a change in pull request #600:  Timeline Service with 
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271927580
 
 

 ##########
 File path: 
hoodie-common/src/main/java/com/uber/hoodie/common/table/timeline/HoodieActiveTimeline.java
 ##########
 @@ -51,14 +52,19 @@
 
   public static final SimpleDateFormat COMMIT_FORMATTER = new 
SimpleDateFormat("yyyyMMddHHmmss");
 
+  //TODO: Ask @nishith what does it take to treat rollback extensions. Is it 
enough if we start archiving Rollback
+  // timeline
+  public static final Set<String> VALID_ROLLBACK_EXTENSIONS = new 
HashSet<>(Arrays.asList(INFLIGHT_ROLLBACK_EXTENSION,
 
 Review comment:
   You want to present them in the timeline only for archival ? If yes, this 
works fine, if you want it to surface in all timelines, we need to test it 
thoroughly since this tampers with the timeline result

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to