n3nash commented on issue #622:  [HUDI-61] Remove payload class dependency in 
SpillableMap
URL: https://github.com/apache/incubator-hudi/pull/622#issuecomment-479975075
 
 
   @arunlakshman Thanks for the explanation, I see what you are trying to say. 
The `Remove payload class dependency in SpillableMap` is a slightly different 
issue than the one you are trying to propose.
    
   That intention of removing payload there is to support spillable map for any 
type T instead of a HoodieRecordPayload (which was the implementation before). 
I think I'll close HUDI-61 since it's not valid anymore. 
   
   What you are suggesting is valid, we require a way to be able to instantiate 
the payload without enforcing some sort of constructor although this changes 
the HoodieRecordPayload interface making it sort of non-backwards compatible if 
we assume we want to deprecate the constructor way going forward. I've opened 
this issue : https://issues.apache.org/jira/browse/HUDI-93. 
   
   Although, I would suggest you to punt on this change since this requires 
some discussions and suggest you to take a look at 
https://issues.apache.org/jira/projects/HUDI/issues/HUDI-92?filter=allopenissues
 is that interests you. If not, you can always see which other task interest 
you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to