bvaradar commented on a change in pull request #631: Performing commit 
archiving in batches to avoid keeping a huge chunk in memory
URL: https://github.com/apache/incubator-hudi/pull/631#discussion_r273269822
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java
 ##########
 @@ -104,6 +105,7 @@
   private static final String DEFAULT_CLEANER_COMMITS_RETAINED = "24";
   private static final String DEFAULT_MAX_COMMITS_TO_KEEP = 
String.valueOf(128);
   private static final String DEFAULT_MIN_COMMITS_TO_KEEP = String.valueOf(96);
+  private static final String DEFAULT_COMMITS_ARCHIVAL_BATCH_SIZE = 
String.valueOf(10);
 
 Review comment:
   Is 10 a good default for both kafka/schemaless tables ? For cloud based 
stores, this number will also influence the number of archive files lying 
around permanently.
   
   Ideally, if we have a SpillableList like implementation and use it here, we 
do need to batch and worry about OOM. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to