bvaradar commented on a change in pull request #623: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/623#discussion_r275448516
########## File path: hoodie-bench/src/main/java/com/uber/hoodie/integrationsuite/workload/WorkloadManager.java ########## @@ -0,0 +1,289 @@ +/* + * Copyright (c) 2019 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * + */ + +package com.uber.hoodie.integrationsuite.workload; + +import com.uber.hoodie.WriteStatus; +import com.uber.hoodie.common.SerializableConfiguration; +import com.uber.hoodie.common.model.HoodieCommitMetadata; +import com.uber.hoodie.common.table.HoodieTableMetaClient; +import com.uber.hoodie.common.table.timeline.HoodieInstant; +import com.uber.hoodie.common.util.ReflectionUtils; +import com.uber.hoodie.common.util.collection.Pair; +import com.uber.hoodie.integrationsuite.configuration.WorkloadOperationConfig; +import com.uber.hoodie.integrationsuite.generator.ComplexKeyGenerator; +import com.uber.hoodie.integrationsuite.generator.WorkloadGenerator; +import com.uber.hoodie.integrationsuite.job.HudiTestSuiteJob.HudiTestSuiteConfig; +import com.uber.hoodie.integrationsuite.job.ThreadPoolService; +import com.uber.hoodie.integrationsuite.job.action.Action; +import com.uber.hoodie.integrationsuite.job.action.CompactAction; +import com.uber.hoodie.integrationsuite.job.action.ValidateAction; +import com.uber.hoodie.integrationsuite.job.action.result.ActionResult; +import com.uber.hoodie.integrationsuite.job.action.result.BooleanResult; +import com.uber.hoodie.integrationsuite.job.action.result.JavaRDDResult; +import com.uber.hoodie.integrationsuite.job.action.result.StringResult; +import com.uber.hoodie.integrationsuite.job.operation.OperationActionSequence; +import com.uber.hoodie.integrationsuite.job.operation.WorkloadOperationSequence; +import com.uber.hoodie.integrationsuite.sink.SinkFormat; +import com.uber.hoodie.integrationsuite.sink.SinkType; +import com.uber.hoodie.integrationsuite.sink.config.DFSSinkConfig; +import com.uber.hoodie.integrationsuite.sink.writer.WriteStats; +import com.uber.hoodie.integrationsuite.validate.IValidate; +import com.uber.hoodie.utilities.deltastreamer.HoodieDeltaStreamer.Operation; +import com.uber.hoodie.utilities.exception.HoodieWorkloadManagerException; +import java.io.IOException; +import java.util.ArrayList; +import java.util.LinkedList; +import java.util.List; +import java.util.Optional; +import java.util.Properties; +import java.util.stream.Collectors; +import org.apache.avro.generic.GenericRecord; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaRDD; +import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.sql.SparkSession; + +/** + * Manages the workload generation and execution sequence provided by an implementation of + * {@link com.uber.hoodie.integrationsuite.configuration.WorkloadOperationSequenceGenerator}. + */ +public class WorkloadManager { + + private static Logger log = Logger.getLogger(WorkloadManager.class); + private WorkloadGenerator workloadGenerator; + private SparkSession sparkSession; + private JavaSparkContext jsc; + private String schemaStr; + private Properties props; + private HudiTestSuiteConfig cfg; + + public WorkloadManager(SparkSession sparkSession, Properties props, JavaSparkContext jsc, String schemaStr, + HudiTestSuiteConfig cfg) { + this.sparkSession = sparkSession; + this.props = props; + this.jsc = jsc; + this.schemaStr = schemaStr; + this.cfg = cfg; + this.workloadGenerator = new WorkloadGenerator( + new DFSSinkConfig(SinkType.valueOf(cfg.sinkTypeName), SinkFormat.valueOf(cfg.sinkFormatName), + new SerializableConfiguration(jsc.hadoopConfiguration()), cfg.inputBasePath, schemaStr, cfg.limitFileSize)); + } + + public Pair<List<JavaRDD<WriteStats>>, List<Pair<JavaRDD<WriteStatus>, List<List<ActionResult>>>>> + generateAndExecuteWorkload(WorkloadOperationSequence workloadOperationSequence, HudiTestSuiteConfig config, + ComplexKeyGenerator keyGenerator) throws Exception { + final WorkloadWriter writer = new WorkloadWriter(jsc, props, cfg, schemaStr); + Pair<List<JavaRDD<WriteStats>>, List<Pair<JavaRDD<WriteStatus>, List<List<ActionResult>>>>> workloadResults = + generateWorkload(workloadOperationSequence, writer, config, keyGenerator); + workloadResults.getRight().addAll(executeWorkload(workloadOperationSequence, writer, config)); + return workloadResults; + } + + public Pair<List<JavaRDD<WriteStats>>, List<Pair<JavaRDD<WriteStatus>, List<List<ActionResult>>>>> generateWorkload( Review comment: The return type is not easy to follow. Can we create a separate type to describe the results. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
